In the OPAC result list with XSLT set to default we show a little icon after 'Type' and before the description: Type: <icon> serial We should show the same icons in the intranet XSLT default result list.
Created attachment 14682 [details] [review] Bug 9403: Material type icons not showing for XSLT default view in intranet Implements the material type icons shown in the MARC21 XSLT result list of the OPAC for the intrant result list. Also adds the system preference DisplayIconsXSLT as an intranet analogue for the OPAC system preference DisplayOPACiconsXSLT and corrects the descriptions of both preferences in the syspref editor. To test: 0) Run database update to add new system preference 1) Activate default XSLTResultsDisplay 2) Check the new system preference DisplayIconsXSLT shows up correctly and is activated by default. Compare descriptions between DisplayIconsXSLT and DisplayOPACiconsXSLT. 3) Check the intranet result list for icons showing up after 'Type:' and before the corresponding description. Detail pages should be showing the 'Type:' as before. 4) Turn off DisplayIconsXSLT. 5) Check the line containing 'Type:', format and audience information is now hidden from the result list. 6) Check that the 'Type:'line is also hidden from the detail page.
Created attachment 14683 [details] [review] Bug 9403: Follow-up: Move "Type" in XSLT result list to match OPAC result list Moves the line starting with "Type:" upwards to show below the author line like it is in the OPAC XSLT result list. To test: 1) Make sure XSLTResultsDisplay and DisplayIconsXSLT are turned on. 2) Check that the line starting with "Type" is showing up below the title and 'by' lines.
Created attachment 15150 [details] [review] [SIGNED-OFF] Bug 9403: Material type icons not showing for XSLT default view in intranet Implements the material type icons shown in the MARC21 XSLT result list of the OPAC for the intrant result list. Also adds the system preference DisplayIconsXSLT as an intranet analogue for the OPAC system preference DisplayOPACiconsXSLT and corrects the descriptions of both preferences in the syspref editor. To test: 0) Run database update to add new system preference 1) Activate default XSLTResultsDisplay 2) Check the new system preference DisplayIconsXSLT shows up correctly and is activated by default. Compare descriptions between DisplayIconsXSLT and DisplayOPACiconsXSLT. 3) Check the intranet result list for icons showing up after 'Type:' and before the corresponding description. Detail pages should be showing the 'Type:' as before. 4) Turn off DisplayIconsXSLT. 5) Check the line containing 'Type:', format and audience information is now hidden from the result list. 6) Check that the 'Type:'line is also hidden from the detail page. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 15171 [details] [review] [SIGNED-OFF] Bug 9403: Follow-up: Move "Type" in XSLT result list to match OPAC result list Moves the line starting with "Type:" upwards to show below the author line like it is in the OPAC XSLT result list. To test: 1) Make sure XSLTResultsDisplay and DisplayIconsXSLT are turned on. 2) Check that the line starting with "Type" is showing up below the title and 'by' lines. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment * passes koha-qa.pl (after a very tiny follow-up for POD, provided as follow-up) * it's MARC21, I haven't checked it worked fine, but it does not break anything passed QA
Created attachment 16663 [details] [review] [PASSED QA] Bug 9403: Material type icons not showing for XSLT default view in intranet Implements the material type icons shown in the MARC21 XSLT result list of the OPAC for the intrant result list. Also adds the system preference DisplayIconsXSLT as an intranet analogue for the OPAC system preference DisplayOPACiconsXSLT and corrects the descriptions of both preferences in the syspref editor. To test: 0) Run database update to add new system preference 1) Activate default XSLTResultsDisplay 2) Check the new system preference DisplayIconsXSLT shows up correctly and is activated by default. Compare descriptions between DisplayIconsXSLT and DisplayOPACiconsXSLT. 3) Check the intranet result list for icons showing up after 'Type:' and before the corresponding description. Detail pages should be showing the 'Type:' as before. 4) Turn off DisplayIconsXSLT. 5) Check the line containing 'Type:', format and audience information is now hidden from the result list. 6) Check that the 'Type:'line is also hidden from the detail page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 16664 [details] [review] [PASSED QA] Bug 9403: Follow-up: Move "Type" in XSLT result list to match OPAC result list Moves the line starting with "Type:" upwards to show below the author line like it is in the OPAC XSLT result list. To test: 1) Make sure XSLTResultsDisplay and DisplayIconsXSLT are turned on. 2) Check that the line starting with "Type" is showing up below the title and 'by' lines. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 16665 [details] [review] [PASSED QA] bug 9403 tiny follow-up to validate podchecker
This patch has been pushed to master.