Bug 9412 - add optional_params to C4::Service
Summary: add optional_params to C4::Service
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Hugh Davenport
QA Contact:
URL:
Keywords:
Depends on: 4437
Blocks: 4439
  Show dependency tree / graph
 
Reported: 2013-01-17 05:15 UTC by Hugh Davenport
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
bug 9412 Add optional_params sub to C4::Service (1.27 KB, patch)
2013-01-17 05:17 UTC, Hugh Davenport 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugh Davenport 2013-01-17 05:15:30 UTC 
Adds a sub to allow getting parameters that aren't required, but may be sent
Comment 1 Hugh Davenport 2013-01-17 05:17:22 UTC 
Created attachment 14651 [details] [review]
bug 9412 Add optional_params sub to C4::Service

Similar to require_params, but just returns undef for any param that
wasn't sent by request

Signed-off-by: Hugh Davenport <hugh@davenport.net.nz>
Comment 2 Bernardo Gonzalez Kriegel 2013-02-19 03:30:15 UTC 
Self-signed
Comment 3 Kyle M Hall 2013-04-12 15:39:36 UTC 
I think this needs a test plan.
Comment 4 Kyle M Hall (khall) 2013-07-05 14:17:58 UTC 
Failed QA for the following reasons:
1) No test plan
2) Adds a subroutine that is not used

Can you please justify the addition of this new subroutine when it isn't used by any new code?
Comment 5 Hugh Davenport 2013-07-05 21:02:50 UTC 
Hi Kyle,

Sorry, when I git bz'd the patch up here, it didn't take into account dependencies which I guess I kinda assumed it would. This bug is actually building blocks for bug 4439 which then use this method. I've updated this bug to show this dependency.

Cheers,

Hugh
Comment 6 Marc Véron 2016-08-22 08:38:05 UTC 
Still valid?
Comment 7 David Cook 2022-08-22 03:04:06 UTC 
This is a legacy module and the linked bug doesn't need C4::Service either