The new renewal notice in the sample SQL file for the web installer should be translated to German.
I'll do a patch for German and Norwegian together.
Created attachment 16253 [details] [review] Bug 9414 - Fix sample letters for German and Norwegian Some letters were missing or not translated in the German and Norwegian data for the webinstaller. This patch adds them. German - RENEWAL (present, but not translated) - OPAC_REG_VERIFY (missing) Norwegian - RENEWAL (present, but not translated) - ISSUESLIP (missing) - ISSUEQSLIP (missing) - RESERVESLIP (missing) - TRANSFERSLIP (missing) - OPAC_REG_VERIFY (missing) To test: - Install Norwegian and German* translations - Run through the web installer in German, making sure that the sample letters are selected - Check that there are no errors in the web installer - Check <intranet>/cgi-bin/koha/tools/letter.pl - that the letters look OK, and are translated - Repeat the process for Norwegian * = I had some problems with installing the German translations that are in master, but now I can't reproduce it. If you run into a problem where only some of the subdirectories of koha-tmpl/intranet-tmpl/prog/de-DE/modules/ are cerated, try downloading and installing the 3.10 .po files from Pootle.
Created attachment 17270 [details] [review] Bug 9414 - Fix sample letters for German and Norwegian Some letters were missing or not translated in the German and Norwegian data for the webinstaller. This patch adds them. German - RENEWAL (present, but not translated) - OPAC_REG_VERIFY (missing) Norwegian - RENEWAL (present, but not translated) - ISSUESLIP (missing) - ISSUEQSLIP (missing) - RESERVESLIP (missing) - TRANSFERSLIP (missing) - OPAC_REG_VERIFY (missing) To test: - Install Norwegian and German* translations - Run through the web installer in German, making sure that the sample letters are selected - Check that there are no errors in the web installer - Check <intranet>/cgi-bin/koha/tools/letter.pl - that the letters look OK, and are translated - Repeat the process for Norwegian * = I had some problems with installing the German translations that are in master, but now I can't reproduce it. If you run into a problem where only some of the subdirectories of koha-tmpl/intranet-tmpl/prog/de-DE/modules/ are cerated, try downloading and installing the 3.10 .po files from Pootle. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 17367 [details] [review] Bug 9414 - Fix sample letters for German and Norwegian Some letters were missing or not translated in the German and Norwegian data for the webinstaller. This patch adds them. German - RENEWAL (present, but not translated) - OPAC_REG_VERIFY (missing) Norwegian - RENEWAL (present, but not translated) - ISSUESLIP (missing) - ISSUEQSLIP (missing) - RESERVESLIP (missing) - TRANSFERSLIP (missing) - OPAC_REG_VERIFY (missing) To test: - Install Norwegian and German* translations - Run through the web installer in German, making sure that the sample letters are selected - Check that there are no errors in the web installer - Check <intranet>/cgi-bin/koha/tools/letter.pl - that the letters look OK, and are translated - Repeat the process for Norwegian * = I had some problems with installing the German translations that are in master, but now I can't reproduce it. If you run into a problem where only some of the subdirectories of koha-tmpl/intranet-tmpl/prog/de-DE/modules/ are cerated, try downloading and installing the 3.10 .po files from Pootle. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Not much to say. Looks good to me. Speak little bit German, and no Norwegian.. Ran this on a empty db. Went fine. Assume that Katrin gave you the German translations.. Passed QA
(In reply to comment #5) > Assume that Katrin gave you the German translations.. Gah, forgot to mention that. Sorry, Katrin!
Thx for letting me mess up your patch with German :)
This patch has been pushed to master and 3.12.x.
Does not apply to 3.10.x please rebase if you wish it on 3.10.x