When exporting some biblio or authorities records with tools/export.pl (via web client or command-line) : If choosing XML format, you get a concatenation of full XML records : <?xml version="1.0" encoding="UTF-8"?> <record> ... </record> <?xml version="1.0" encoding="UTF-8"?> <record> ... </record> ... This file should have a root node. It should use MARC::File::XML: http://search.cpan.org/~gmcharlt/MARC-XML-0.93/lib/MARC/File/XML.pm#close%28%29
Created attachment 14658 [details] [review] Proposed patch See commit comment
Created attachment 14660 [details] [review] Proposed patch Little update of patch to format with perltidy
Created attachment 14661 [details] [review] Proposed patch (Wrong previous patch upload)
Created attachment 14719 [details] [review] Bug 9415: XML catalog export is missing root node When exporting some biblio or authorities records with tools/export.pl (via web client or command-line) : If choosing XML format, you get a concatenation of full XML records. This patch uses MARC::File::XML to create a well formated file. See http://search.cpan.org/~gmcharlt/MARC-XML-0.93/lib/MARC/File/XML.pm#close%28%29 Test plan: - Go to Tools/Export data - Enter numbers in from and to biblio number (make sure that at least two records will be exported). - Select xml in file format - Click "Export bibliographic records" - Save file somewhere - Look at downloaded file => File should look like : <?xml version="1.0" encoding="UTF-8"?> <collection ... <record> ... </record> <record> ... </record> </collection> => "collection" is the root node and XML declaration exists only once - Do the same for authorities export and command-line use of tools/export.pl Second test plan: - From the command line, run tools/export.pl, e.g., tools/export.pl --format=xml --filename=bibs.xml - Verify that the output is valid XML, e.g., xmllint --noout bibs.xml # if the file is valid, no error messages will be displayed Signed-off-by: Galen Charlton <gmc@esilibrary.com>
QA comment * small patch, that sounds logical and fixes a nasty problem * passes koha-qa.pl passed QA
Created attachment 16432 [details] [review] Bug 9415: XML catalog export is missing root node When exporting some biblio or authorities records with tools/export.pl (via web client or command-line) : If choosing XML format, you get a concatenation of full XML records. This patch uses MARC::File::XML to create a well formated file. See http://search.cpan.org/~gmcharlt/MARC-XML-0.93/lib/MARC/File/XML.pm#close%28%29 Test plan: - Go to Tools/Export data - Enter numbers in from and to biblio number (make sure that at least two records will be exported). - Select xml in file format - Click "Export bibliographic records" - Save file somewhere - Look at downloaded file => File should look like : <?xml version="1.0" encoding="UTF-8"?> <collection ... <record> ... </record> <record> ... </record> </collection> => "collection" is the root node and XML declaration exists only once - Do the same for authorities export and command-line use of tools/export.pl Second test plan: - From the command line, run tools/export.pl, e.g., tools/export.pl --format=xml --filename=bibs.xml - Verify that the output is valid XML, e.g., xmllint --noout bibs.xml # if the file is valid, no error messages will be displayed Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.5