If the highlight feature is enabled and you search a string with a space, the browser (tested with Firefox) uses CPU at 100% during some seconds.
Created attachment 14676 [details] [review] Bug 9419: The highlight feature can cause a browser freeze Test plan: - switch on the OpacHighlightedWords syspref - search at the opac and intranet a string with a space (e.g. au,wrdl:"Shakespeare, William" note the double space after the comma) - without the patch your browser will be frozen during a few seconds, after applying it, the highlight works better.
Created attachment 15190 [details] [review] Bug 9419: The highlight feature can cause a browser freeze Test plan: - switch on the OpacHighlightedWords syspref - search at the opac and intranet a string with a space (e.g. au,wrdl:"Shakespeare, William" note the double space after the comma) - without the patch your browser will be frozen during a few seconds, after applying it, the highlight works better. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 16832 [details] [review] Bug 9419: The highlight feature can cause a browser freeze Test plan: - switch on the OpacHighlightedWords syspref - search at the opac and intranet a string with a space (e.g. au,wrdl:"Shakespeare, William" note the double space after the comma) - without the patch your browser will be frozen during a few seconds, after applying it, the highlight works better. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Could not really detect any change while testing. But the additional testing on the array will not hurt.. Passed QA
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12