When trying to checkout an item that is not for loan (due to items.notforloan value or because itemtype is not for loan), you get a confirmation or blocking message (depending on AllowNotForLoanOverride syspref). This message tells "Item is normally not for loan". I propose to add some informations : if itemtype is not for loan, tell "Item type is normally not for loan". if item is not for loan due to items.notforloan value, add notforloan description to message.
Created attachment 14695 [details] [review] Proposed patch
Created attachment 14696 [details] [review] [SIGNED-OFF] Bug 9423: Add notforloan value to issue confirmation or blocking message When trying to checkout an item that is not for loan (due to items.notforloan value or because itemtype is not for loan), you get a confirmation or blocking message (depending on AllowNotForLoanOverride syspref). This message tells "Item is normally not for loan". This patch adds some informations : if itemtype is not for loan, tells "Item type is normally not for loan". if item is not for loan due to items.notforloan value, adds notforloan description to message. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works as advertised: Not for loan authorized value is correctly shown.
QA comment * small patch, no side effect risk, only a display improvement * passes koha-qa.pl * works as described, the test plan is trivial: TEST PLAN * search for an item that has a notforloan flag set * check-out this item to a patron * the error message now has the notforloan description displayed passed QA
Created attachment 16359 [details] [review] Bug 9423: Add notforloan value to issue confirmation or blocking message When trying to checkout an item that is not for loan (due to items.notforloan value or because itemtype is not for loan), you get a confirmation or blocking message (depending on AllowNotForLoanOverride syspref). This message tells "Item is normally not for loan". This patch adds some informations : if itemtype is not for loan, tells "Item type is normally not for loan". if item is not for loan due to items.notforloan value, adds notforloan description to message. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works as advertised: Not for loan authorized value is correctly shown. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.5