Bug 9423 - Add notforloan value to issue confirmation or blocking message
Summary: Add notforloan value to issue confirmation or blocking message
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin Somers
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 13:31 UTC by Fridolin Somers
Modified: 2014-05-26 21:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (5.10 KB, patch)
2013-01-18 13:35 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9423: Add notforloan value to issue confirmation or blocking message (5.27 KB, patch)
2013-01-18 13:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9423: Add notforloan value to issue confirmation or blocking message (5.25 KB, patch)
2013-03-19 10:11 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-01-18 13:31:24 UTC
When trying to checkout an item that is not for loan (due to items.notforloan value or because itemtype is not for loan), you get a confirmation or blocking message (depending on AllowNotForLoanOverride syspref).
This message tells "Item is normally not for loan".

I propose to add some informations : 
if itemtype is not for loan, tell "Item type is normally not for loan".
if item is not for loan due to items.notforloan value, add notforloan description to message.
Comment 1 Fridolin Somers 2013-01-18 13:35:28 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-01-18 13:55:33 UTC Comment hidden (obsolete)
Comment 3 Paul Poulain 2013-03-19 10:10:37 UTC
QA comment
 * small patch, no side effect risk, only a display improvement
 * passes koha-qa.pl
 * works as described, the test plan is trivial:

TEST PLAN
 * search for an item that has a notforloan flag set
 * check-out this item to a patron
 * the error message now has the notforloan description displayed

passed QA
Comment 4 Paul Poulain 2013-03-19 10:11:14 UTC
Created attachment 16359 [details] [review]
Bug 9423: Add notforloan value to issue confirmation or blocking message

When trying to checkout an item that is not for loan (due to
items.notforloan value or because itemtype is not for loan), you get a
confirmation or blocking message (depending on AllowNotForLoanOverride
syspref).

This message tells "Item is normally not for loan".

This patch adds some informations :
if itemtype is not for loan, tells "Item type is normally not for loan".
if item is not for loan due to items.notforloan value, adds notforloan
description to message.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Works as advertised: Not for loan authorized value is correctly shown.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 5 Jared Camins-Esakov 2013-03-20 02:23:57 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2013-03-29 06:37:40 UTC
Pushed to 3.10.x will be in 3.10.5