The Authority MARC frameworks page uses the old tablesorter plugin. It should be replaced with the DataTables plugin.
Created attachment 14708 [details] [review] Bug 9428 - Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly.
Created attachment 14747 [details] [review] Bug 9428 - Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry.
Created attachment 14880 [details] [review] Bug 9428 - Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry.
Created attachment 15690 [details] [review] Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets.
Created attachment 15737 [details] [review] [SIGNED-OFF] Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors.
Owen, Is there a reason you didn't keep my changes (aLengthMenu key) in your new patch? I can re add it in my sign off patch if needed.
QA comment: This patch replaces tablesorter with datatable on the auth framework page. Owen said me that the aLengthMenu has to be present on the patch, so I will re-add it in my sign-off patch. Marked as Passed QA.
Created attachment 15878 [details] [review] Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables
This patch has been pushed to master.