Bug 9428 - Use DataTables in Authority MARC frameworks page
Summary: Use DataTables in Authority MARC frameworks page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 17:59 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9428 - Use DataTables in Authority MARC frameworks page (3.21 KB, patch)
2013-01-18 19:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9428 - Use DataTables in Authority MARC frameworks page (3.34 KB, patch)
2013-01-22 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9428 - Use DataTables in Authority MARC frameworks page (3.34 KB, patch)
2013-01-28 08:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page (3.26 KB, patch)
2013-02-26 15:15 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page (3.33 KB, patch)
2013-02-27 21:30 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page (3.50 KB, patch)
2013-03-05 08:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-01-18 17:59:08 UTC
The Authority MARC frameworks page uses the old tablesorter plugin. It should be replaced with the DataTables plugin.
Comment 1 Owen Leonard 2013-01-18 19:07:09 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-01-22 14:52:46 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-01-28 08:04:22 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2013-02-26 15:15:53 UTC Comment hidden (obsolete)
Comment 5 Bernardo Gonzalez Kriegel 2013-02-27 21:30:18 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-02-28 15:39:59 UTC
Owen,
Is there a reason you didn't keep my changes (aLengthMenu key) in your new patch?
I can re add it in my sign off patch if needed.
Comment 7 Jonathan Druart 2013-03-05 08:30:26 UTC
QA comment:

This patch replaces tablesorter with datatable on the auth framework page.
Owen said me that the aLengthMenu has to be present on the patch, so I will re-add it in my sign-off patch.

Marked as Passed QA.
Comment 8 Jonathan Druart 2013-03-05 08:30:38 UTC
Created attachment 15878 [details] [review]
Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page

Replace the tablesorter plugin with the DataTables plugin on the
Authority MARC frameworks page.

To test, open the Authority MARC frameworks page (Authority types ->
MARC structure). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the aLengthMenu key for DataTables
Comment 9 Jared Camins-Esakov 2013-03-07 15:54:51 UTC
This patch has been pushed to master.