9429 – Use DataTables on Authorized Values page

Bug 9429 - Use DataTables on Authorized Values page

Summary: Use DataTables on Authorized Values page

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Owen Leonard
QA Contact:	Jonathan Druart

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-01-18 19:19 UTC by Owen Leonard
Modified:	2014-05-26 21:04 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9429 - Use DataTables on Authorized Values page (3.18 KB, patch) 2013-01-18 19:32 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 9429 - Use DataTables on Authorized Values page (3.31 KB, patch) 2013-01-22 14:55 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 9429 - Use DataTables on Authorized Values page (3.31 KB, patch) 2013-01-28 08:05 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 9429 [Revised] Use DataTables on Authorized Values page (3.10 KB, patch) 2013-02-26 15:21 UTC, Owen Leonard	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 9429 [Revised] Use DataTables on Authorized Values page (3.18 KB, patch) 2013-02-27 23:17 UTC, Bernardo Gonzalez Kriegel	Details \| Diff \| Splinter Review
Bug 9429 [Revised] Use DataTables on Authorized Values page (3.35 KB, patch) 2013-03-05 08:41 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2013-01-18 19:19:33 UTC

The Authorized Values page uses the old tablesorter plugin. It should be replaced with the DataTables plugin.

Comment 1 Owen Leonard 2013-01-18 19:32:15 UTC Comment hidden (obsolete)

Created attachment 14709 [details] [review]
Bug 9429 - Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration -> Authorized
values). Confirm that table sorting works correctly.

Comment 2 Jonathan Druart 2013-01-22 14:55:30 UTC Comment hidden (obsolete)

Created attachment 14748 [details] [review]
Bug 9429 - Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration -> Authorized
values). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the "All" entry.

Comment 3 Jonathan Druart 2013-01-28 08:05:09 UTC Comment hidden (obsolete)

Created attachment 14881 [details] [review]
Bug 9429 - Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration -> Authorized
values). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the "All" entry.

Comment 4 Owen Leonard 2013-02-26 15:21:03 UTC Comment hidden (obsolete)

Created attachment 15692 [details] [review]
Bug 9429 [Revised] Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration -> Authorized
values). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Comment 5 Bernardo Gonzalez Kriegel 2013-02-27 23:17:54 UTC Comment hidden (obsolete)

Created attachment 15738 [details] [review]
[SIGNED-OFF] Bug 9429 [Revised] Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration -> Authorized
values). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.

Comment 6 Jonathan Druart 2013-03-05 08:40:42 UTC

QA comment:

This patch replaces tablesorter with datatables on the authorized values page.
All works great. Just one small remark: the "no limitation" is sorted after the "XXX limitations". But it is not blocker at all.

Marked as Passed QA.

Comment 7 Jonathan Druart 2013-03-05 08:41:22 UTC

Created attachment 15879 [details] [review]
Bug 9429 [Revised] Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration -> Authorized
values). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the aLengthMenu key for DataTables

Comment 8 Jared Camins-Esakov 2013-03-07 15:52:27 UTC

This patch has been pushed to master.