The library transfer limits page uses the old tablesorter plugin. It should be replaced with the DataTables plugin.
Created attachment 14713 [details] [review] Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly.
Created attachment 14749 [details] [review] Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry.
Created attachment 14882 [details] [review] Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry.
Created attachment 15693 [details] [review] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets.
Created attachment 15739 [details] [review] [SIGNED-OFF] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors.
QA comment: This patch replaces tablesorter with datatable on the branch transfer limits page. A little ergonomic issue: the table in the first tab has not the same width as others (the "min-width: 50%;" is not adequate). Marked as Passed QA.
Created attachment 15880 [details] [review] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager)
This patch has been pushed to master.