The Patron Category Administration page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Created attachment 14720 [details] [review] Bug 9431 - Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Authorized Values page (Administration -> Patron types and categories). Confirm that table sorting works correctly.
Created attachment 14721 [details] [review] Bug 9431 - Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly.
Owen, At least 3 columns are not sorted correctly: "Enrollment period", "Age required" and "Upper age limit". It is caused by a mix between integer and string. Marked as Failed QA.
(In reply to comment #3) > At least 3 columns are not sorted correctly: > "Enrollment period", "Age required" and "Upper age limit". > It is caused by a mix between integer and string. Good catch. I see now these columns weren't sorted correctly before this patch either, but an update shouldn't perpetuate the bug.
Created attachment 14915 [details] [review] Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc.
Created attachment 14956 [details] [review] Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu values.
Created attachment 15695 [details] [review] Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc. Further revision corrects template path to datatables assets.
Owen, you forgot the aLengthMenu key.
Hi Jonathan - should this be failed QA to make it show up on Owen's radar? :)
Katrin, Perhaps he deliberately forgot it but I don't know why. So yes, I switch to Failed QA.
Created attachment 15870 [details] [review] Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc. Further revision corrects template path to datatables assets.
Created attachment 15959 [details] [review] [SIGNED-OFF] Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc. Further revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors.
QA comment: The natural sort works great. The version 0.7 is available on http://www.datatables.net/plug-ins/sorting Marked as Passed QA.
Created attachment 15968 [details] [review] Bug 9431 [Revised] Use DataTables on Patron Category Administration page Replace the tablesorter plugin with the DataTables plugin on the patron category administration page. Structural changes were made to the table markup for validity and to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, open the Patron Category Administration page (Administration -> Patron types and categories). Confirm that table sorting works correctly. Revision adds a "natural sort" plugin to the main datatables configuration JavaScript file to enable sorting of columns like those in this table which include mixed numeric and text data. Allows correct numeric sorting of data like "0 years, 1 years, 2 years, 18 years," etc. Further revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.