I get the following error: Can't call method "param" on an undefined value at /home/jcamins/kohaclone/acqui/addorderiso2709.pl line 445. at /home/jcamins/kohaclone/acqui/addorderiso2709.pl line 450
Created attachment 14722 [details] [review] Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful.
Created attachment 15080 [details] [review] Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected.
Simple patch, works with Plack and Apache. Marked as Passed QA.
Created attachment 15100 [details] [review] Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.3