Bug 9435 - Use DataTables on libraries and groups administration page
Summary: Use DataTables on libraries and groups administration page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-19 23:58 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9435 - Use DataTables on libraries and groups administration page (3.39 KB, patch)
2013-01-20 00:28 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 9435 - Use DataTables on libraries and groups administration page (3.52 KB, patch)
2013-01-22 15:22 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 9435 - Use DataTables on libraries and groups administration page (3.52 KB, patch)
2013-01-28 08:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 9435 [Revised] Use DataTables on libraries and groups administration page (2.94 KB, patch)
2013-02-26 15:51 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9435 [Revised] Use DataTables on libraries and groups administration page (3.01 KB, patch)
2013-02-27 23:23 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
Bug 9435 [Revised] Use DataTables on libraries and groups administration page (3.39 KB, patch)
2013-03-05 09:08 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-01-19 23:58:28 UTC 
The libraries and groups administration page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Comment 1 Owen Leonard 2013-01-20 00:28:39 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-01-22 15:22:37 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-01-22 15:24:22 UTC 
There are 2 others tables on this page. It would be great to have datatable on them too in order to have a consistency.
Comment 4 Jonathan Druart 2013-01-28 08:06:54 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2013-02-26 15:51:24 UTC Comment hidden (obsolete)
Comment 6 Bernardo Gonzalez Kriegel 2013-02-27 23:23:35 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-03-05 09:08:37 UTC 
QA comment:

This patch replaces tablesorter with datatable on one of the tables of the libraries and groups page.

This page contains 3 tables, it would be great if a followup (on another report) can be provided for these 2 others tables.

Marked as Passed QA.
Comment 8 Jonathan Druart 2013-03-05 09:08:53 UTC 
Created attachment 15881 [details] [review]
Bug 9435 [Revised] Use DataTables on libraries and groups administration page

Replace the tablesorter plugin with the DataTables plugin on the
libraries and groups administration page.

To test, open the libraries and groups administration page (Administration
-> Libraries and groups). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Sort works. No errors.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the aLengthMenu key for DataTables + delete an unused
div block (used for pager)
Comment 9 Jared Camins-Esakov 2013-03-07 15:56:35 UTC 
This patch has been pushed to master.