9437 – Use DataTables on itemtypes administration page

Bug 9437 - Use DataTables on itemtypes administration page

Summary: Use DataTables on itemtypes administration page

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Owen Leonard
QA Contact:	Jonathan Druart

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-01-20 01:12 UTC by Owen Leonard
Modified:	2014-05-26 21:04 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9437 - Use DataTables on itemtypes administration page (2.58 KB, patch) 2013-01-20 01:19 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 9437 - Use DataTables on itemtypes administration page (2.72 KB, patch) 2013-01-22 14:46 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 9437 - Use DataTables on itemtypes administration page (2.72 KB, patch) 2013-01-28 08:03 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 9437 [Revised] Use DataTables on itemtypes administration page (2.70 KB, patch) 2013-02-26 16:07 UTC, Owen Leonard	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 9437 [Revised] Use DataTables on itemtypes administration page (2.77 KB, patch) 2013-02-27 23:30 UTC, Bernardo Gonzalez Kriegel	Details \| Diff \| Splinter Review
Bug 9437 [Revised] Use DataTables on itemtypes administration page (2.96 KB, patch) 2013-03-05 09:41 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2013-01-20 01:12:04 UTC

The itemtypes administration page uses the old tablesorter plugin. It should use the DataTables plugin instead.

Comment 1 Owen Leonard 2013-01-20 01:19:28 UTC Comment hidden (obsolete)

Created attachment 14725 [details] [review]
Bug 9437 - Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
-> Item types). Confirm that table sorting works correctly.

Comment 2 Jonathan Druart 2013-01-22 14:46:58 UTC Comment hidden (obsolete)

Created attachment 14746 [details] [review]
Bug 9437 - Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
-> Item types). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the "All" entry.

Comment 3 Jonathan Druart 2013-01-28 08:03:37 UTC Comment hidden (obsolete)

Created attachment 14879 [details] [review]
Bug 9437 - Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
-> Item types). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Add the "All" entry.

Comment 4 Owen Leonard 2013-02-26 16:07:55 UTC Comment hidden (obsolete)

Created attachment 15698 [details] [review]
Bug 9437 [Revised] Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
-> Item types). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Comment 5 Bernardo Gonzalez Kriegel 2013-02-27 23:30:26 UTC Comment hidden (obsolete)

Created attachment 15742 [details] [review]
[SIGNED-OFF] Bug 9437 [Revised] Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
-> Item types). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Sorting works. No errors.

Comment 6 Jonathan Druart 2013-03-05 09:40:25 UTC

QA comment:
This patch replace tablesorter with DT on the itemtypes admin page.
Nothing to say.
Marked as Passed QA.

Comment 7 Jonathan Druart 2013-03-05 09:41:26 UTC

Created attachment 15883 [details] [review]
Bug 9437 [Revised] Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
-> Item types). Confirm that table sorting works correctly.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Sorting works. No errors.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Delete an unused div block (used for pager).

Comment 8 Jared Camins-Esakov 2013-03-07 15:46:05 UTC

This patch has been pushed to master.