The sql in C4::Acquisitions::GetBasketgroups contains mysql specific backtick quotes. We have been removing these from sql files. They should be removed from the code for consistency
Created attachment 14777 [details] [review] Proposed patch Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected
Created attachment 14897 [details] [review] [SIGNED-OFF] Bug 9455: Remove unnecessary quoting from sql Wa've removed the mysql specific back quotes from sql files But this case remained of them embedded in an sql string Also removed the unnecessary call to finish and temporary variable in the subroutine return Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to test instructions: Basketgroups functionality appears to work normally.
Created attachment 15480 [details] [review] [PASSED QA] Bug 9455: Remove unnecessary quoting from sql Wa've removed the mysql specific back quotes from sql files But this case remained of them embedded in an sql string Also removed the unnecessary call to finish and temporary variable in the subroutine return Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to test instructions: Basketgroups functionality appears to work normally. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked SQL produces the same results as before and did some tests on the basket group functionality.
This patch has been pushed to master.