Bug 9455 - Embedded mysql quotes in sql string
Summary: Embedded mysql quotes in sql string
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Colin Campbell
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 11:53 UTC by Colin Campbell
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.44 KB, patch)
2013-01-23 12:01 UTC, Colin Campbell
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9455: Remove unnecessary quoting from sql (1.74 KB, patch)
2013-01-28 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 9455: Remove unnecessary quoting from sql (1.85 KB, patch)
2013-02-17 18:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2013-01-23 11:53:01 UTC
The sql in C4::Acquisitions::GetBasketgroups contains mysql specific backtick quotes. We have been removing these from sql files. They should be removed from the code for consistency
Comment 1 Colin Campbell 2013-01-23 12:01:30 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-01-28 15:14:09 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 18:11:10 UTC
Created attachment 15480 [details] [review]
[PASSED QA] Bug 9455: Remove unnecessary quoting from sql

Wa've removed the mysql specific back quotes from sql files
But this case remained of them embedded in an sql string
Also removed the unnecessary call to finish
and temporary variable in the subroutine return

Testing: Functionality should remain unchanged. Retrieval of
basketgroups in acquisitions should not be affected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Works according to test instructions: Basketgroups
functionality appears to work normally.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked SQL produces the same results as before and did some
tests on the basket group functionality.
Comment 4 Jared Camins-Esakov 2013-02-20 13:23:25 UTC
This patch has been pushed to master.