Bug 9461 - Use DataTables on holds awaiting pickup report page
Summary: Use DataTables on holds awaiting pickup report page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL: /cgi-bin/koha/circ/waitingreserves.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 16:41 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9461 - Use DataTables on holds awaiting pickup report page (2.71 KB, patch)
2013-01-23 16:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9461 [Revised] Use DataTables on holds awaiting pickup report page (2.82 KB, patch)
2013-01-25 14:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9461 [Revised] Use DataTables on holds awaiting pickup report page (2.83 KB, patch)
2013-02-08 17:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9461 [Revised] Use DataTables on holds awaiting pickup report page (2.90 KB, patch)
2013-02-14 13:42 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-01-23 16:41:40 UTC
The holds awaiting pickup page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Comment 1 Owen Leonard 2013-01-23 16:45:23 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-01-25 14:15:43 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-02-08 17:28:46 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-02-14 13:42:37 UTC
QA comment:

replace tablesorter with datatable on the the holds awaiting page.
No regression found.

Marked as Passed QA.
Comment 5 Jonathan Druart 2013-02-14 13:42:49 UTC
Created attachment 15317 [details] [review]
Bug 9461 [Revised] Use DataTables on holds awaiting pickup report page

Replace the tablesorter plugin with the DataTables plugin on the
holds awaiting pickup report page.

To test, open the holds awaiting pickup report (Circulation
-> Holds awaiting pickup). Confirm that table sorting works correctly on
all tables.

Revision makes default result count (20) match options for number of
pagination entries (10,20,50,100,all).

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jared Camins-Esakov 2013-02-15 13:44:28 UTC
This patch has been pushed to master.