The patron detail page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Created attachment 14795 [details] [review] Bug 9462 - Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables.
Hi Owen, The holdst is really small and does not extend to the width of the container (div id="holdst_wrapper"). I don't know why, I did not find the difference with the issuest table.
(In reply to comment #2) > The holdst is really small and does not extend to the width of the container I noticed this on the branch transfers page as well. If you have a sorted table in a hidden tab the table doesn't expand to the width one would expect. On the branch transfers page I ended up setting an explicit min-width on the table. When I tested this patch the problem wasn't as noticeable, but that was probably due to the data I had in the table. Setting an explicit width here too could be a solution. I would like to see a screenshot if that is possible.
Created attachment 14843 [details] Patron detail > holds table issue (In reply to comment #3) > Setting an explicit width here too could be a solution. I would like to see > a screenshot if that is possible. Yes of course. If I set a width=100% for the table element, the table appears with a good width.
Created attachment 14917 [details] [review] Bug 9462 [Revised] Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. Revision adds some JavaScript designed to handle table-sizing for tables which are hidden initally in tabs. DataTables has an approved method for handling these cases: http://www.datatables.net/examples/api/tabs_and_scrolling.html This should prevent the table of existing holds from looking squeezed.
Created attachment 15180 [details] [review] Bug 9462 [Revised] Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. Revision adds some JavaScript designed to handle table-sizing for tables which are hidden initally in tabs. DataTables has an approved method for handling these cases: http://www.datatables.net/examples/api/tabs_and_scrolling.html This should prevent the table of existing holds from looking squeezed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment: The table is correctly displayed now. There is a sort issue on the barcode column if it contains something else than a barcode (e.g. "Item is waiting -barcode-"), not blocker. Marked as Passed QA.
Created attachment 15223 [details] [review] Bug 9462 [Revised] Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. Revision adds some JavaScript designed to handle table-sizing for tables which are hidden initally in tabs. DataTables has an approved method for handling these cases: http://www.datatables.net/examples/api/tabs_and_scrolling.html This should prevent the table of existing holds from looking squeezed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.