Bug 9464 - Update DataTables configuration on patron statistics page
Summary: Update DataTables configuration on patron statistics page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Paul Poulain
URL: /cgi-bin/koha/members/statistics.pl?b...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 17:42 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 9464 - Update DataTables configuration on patron statistics page (1.70 KB, patch)
2013-01-23 17:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9464 - Update DataTables configuration on patron statistics page (1.73 KB, patch)
2013-01-24 11:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 9464 - Update DataTables configuration on patron statistics page (1.79 KB, patch)
2013-03-20 17:14 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-01-23 17:42:03 UTC
The patron statistics page still has a link to the old tablesorter plugin which should be removed. The DataTables configuration can be changed in such a way that empty filter boxes don't appear.
Comment 1 Owen Leonard 2013-01-23 17:45:19 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-01-24 11:03:14 UTC Comment hidden (obsolete)
Comment 3 Paul Poulain 2013-03-20 17:13:54 UTC
QA comment:
 * passes koha-qa
 * tiny template only patch

passed QA
Comment 4 Paul Poulain 2013-03-20 17:14:24 UTC
Created attachment 16552 [details] [review]
[PASSED QA] Bug 9464 - Update DataTables configuration on patron statistics page

This page removes an unnecessary link to the old tablesorter plugin and
changes the configuration details of the DataTables plugin so that an
empty filter box doesn't appear as dot above and below the table (an
empty <div> with a 1-pixel border).

To test, open the patron statistics page for a patron who has entries to
display. Sorting should work normally and no dots should be seen.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 5 Jared Camins-Esakov 2013-03-20 19:29:36 UTC
This patch has been pushed to master.