Bug 9471 - Use DataTables on serials claims page
Summary: Use DataTables on serials claims page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL: /cgi-bin/koha/serials/claims.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 20:25 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9471 - Use DataTables on serials claims page (4.62 KB, patch)
2013-01-23 20:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Signed-off patch (5.01 KB, patch)
2013-02-09 20:30 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 9471 - Use DataTables on serials claims page (5.07 KB, patch)
2013-02-11 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-01-23 20:25:12 UTC
The serials claims page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Comment 1 Owen Leonard 2013-01-23 20:33:46 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2013-02-09 20:30:24 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-02-11 09:50:09 UTC
QA comment:

All filters and sorts work.

It would be great to use the DataTables's filters instead of a "manual" way.

I proposed a patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8910) in order to use the DT server-side processing for this table, but the first step (Bug 5342) is waiting signoffs for a long time.

Marked as Passed QA.
Comment 4 Jonathan Druart 2013-02-11 09:50:28 UTC
Created attachment 15227 [details] [review]
Bug 9471 - Use DataTables on serials claims page

Replace the tablesorter plugin with the DataTables plugin on the
serials claims page.

This patch replaces some custom table fitlering code with code which
uses DataTables' built-in table fitlering. A minor correction to markup
has also been made to properly align inputs in the filter form.

To test, run the serials claims report for a vendor with data which will
populate results. Confirm that table sorting works correctly. Confirm
also that filtering by title and branch works.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Works as advertised. I have compared side by side the both pages, with
tablesorter, and with DataTables. The both work. No regression. With
DataTables, no more sorting on Begin clam column, which is great. A new sort
option may be usefull on the Library column (wasn't the with tablesorter
neither).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2013-02-12 14:15:08 UTC
This patch has been pushed to master.