In the member notices page, the time column is not displayed according the syspref format
Created attachment 14811 [details] [review] Bug 9479: The member notices page does not display dates in the syspref format In order to let the KohaDates plugin display a datetime, this patch modify this plugin. Now it uses Koha::DateUtils instead of C4::Dates. Test plan: - check that the date format on the member notices page (members/notices.pl) is displayed according your syspref dateformat. - check that existing dates are always in the good format (without the hours) e.g. acqui/histsearch.pl, acqui/basket.pl, etc. - Modify your syspref and recheck the previous pages
Created attachment 14859 [details] [review] [SIGNED-OFF] Bug 9479: The member notices page doesn't display dates in the syspref format In order to let the KohaDates plugin display a datetime, this patch modify this plugin. Now it uses Koha::DateUtils instead of C4::Dates. Test plan: - check that the date format on the member notices page (members/notices.pl) is displayed according your syspref dateformat. - check that existing dates are always in the good format (without the hours) e.g. acqui/histsearch.pl, acqui/basket.pl, etc. - Modify your syspref and recheck the previous pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice addition, and works according to the test plan. A nice follow-up would be to create a system pref for formatting times (12/24hr).
>This is a nice addition, and works according to the test plan. A nice >follow-up would be to create a system pref for formatting times >(12/24hr). Actually Kyle did that in bug 9014 I think :)
I followed the test plan and applied the patch on top of 9014 as this is probably going to be pushed first. On acquisition history search (order search) the time is displayed in the column "placed on" where it should not be. Jonathan - could you check please?
Created attachment 16722 [details] [review] Bug 9479: FIX conflict with Bug 9014 3rd parameters of output_pref is already used
Created attachment 16909 [details] [review] [PASSED QA] Bug 9479: The member notices page doesn't display dates in the syspref format In order to let the KohaDates plugin display a datetime, this patch modify this plugin. Now it uses Koha::DateUtils instead of C4::Dates. Test plan: - check that the date format on the member notices page (members/notices.pl) is displayed according your syspref dateformat. - check that existing dates are always in the good format (without the hours) e.g. acqui/histsearch.pl, acqui/basket.pl, etc. - Modify your syspref and recheck the previous pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice addition, and works according to the test plan. A nice follow-up would be to create a system pref for formatting times (12/24hr). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a tab in notices.tt to make QA script happy.
Created attachment 16910 [details] [review] [PASSED QA] Bug 9479: FIX conflict with Bug 9014 3rd parameters of output_pref is already used Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Checked sorting and display on notices page with various settings for dateformat and TimeFormat system preferences. Also checked other pages for correct display: - List of checkouts in patron account - Order search result list - Basket list in vendor search - Staff detail page
I had already started testing this during the hackfest so I wanted to finish my review.
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.6