A number of libraries have asked why the HOLDPLACED notice allows you to choose item level fields but they are never filled in. There is no reason to disallow the use of items fields in the HOLDPLACED notice. For bib-level holds they will not be populated, but as long as the libraries know this, it does not seem like it would be an issue. It would probably be best to add a note about this in the manual.
Created attachment 14836 [details] [review] Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Test Plan: 1) Enable the syspref emailLibrarianWhenHoldIsPlaced 2) Modify the HOLDPLACED notice, add some item level fields 3) Place an item level hold 4) Check the email you recieve ( or just look at it from the db ) You should see the item level fields are new populated
Created attachment 14838 [details] [review] Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Test Plan: 1) Enable the syspref emailLibrarianWhenHoldIsPlaced 2) Modify the HOLDPLACED notice, add some item level fields 3) Place an item level hold 4) Check the email you recieve ( or just look at it from the db ) You should see the item level fields are new populated
I'm not sure to use the good field for this test. I try to add <<reserves.priority>> in the notice HOLDPLACED but it doesn't appear in the email. Which fields can be add to add to test the item level
Created attachment 18833 [details] [review] [SIGNED-OFF] Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Looks fine, however there could be some unwanted effects (blanks) in case of placing a hold on the next available.
Created attachment 19538 [details] [review] [PASSED QA] Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Test Plan: 1) Enable the syspref emailLibrarianWhenHoldIsPlaced 2) Modify the HOLDPLACED notice, add some item level fields 3) Place an item level hold 4) Check the email you receive ( or just look at it from the db ) You should see the item level fields are new populated Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Amended test plan: 5) Place a title level hold 6) Check the email you receive - item fields are not populated, but notice still looks ok.
Pushed to master. Thanks, Kyle!