Bug 9493 - confirmations for user holds in opac are not translatable
Summary: confirmations for user holds in opac are not translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 15:02 UTC by Fridolin Somers
Modified: 2017-08-15 10:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (3.64 KB, patch)
2013-01-25 15:08 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9493: confirmations for user holds in opac are not translatable (3.74 KB, patch)
2013-01-28 14:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9493: confirmations for user holds in opac are not translatable (3.75 KB, patch)
2013-02-07 14:47 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-01-25 15:02:26 UTC
In opac-user.tt, javascript for user holds confirmations (cancel, suspend, resume) are not translatable.
This is because text is in onclick attribute, withtout javascript method for translatable strings : _().
Those strings should be variables in script tag.
Comment 1 Fridolin Somers 2013-01-25 15:08:22 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-01-28 14:38:12 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-02-07 14:47:18 UTC
QA comment:

This patch makes 3 strings translatable at the OPAC.

Marked as Passed QA.
Comment 4 Jonathan Druart 2013-02-07 14:47:32 UTC
Created attachment 15142 [details] [review]
Bug 9493: confirmations for user holds in opac are not translatable

In opac-user.tt, javascript for user holds confirmations (cancel, suspend, resume) are not translatable.
This is because text is in onclick attribute, withtout javascript method for translatable strings : _().

This patch moves those strings as variables into script tag and sets them translatable.

Test plan :
- set a hold for a user
- Go to OPAC user page "my summary"
- click on "Cancel"
=> you get a confirmation message
- click on "Suspend all holds"
=> you get a confirmation message
- click on "Resume all suspended holds"
=> you get a confirmation message
Test this is 'en' and another language.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2013-02-08 00:26:14 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2013-02-08 23:50:27 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
Comment 7 Katrin Fischer 2017-08-15 10:59:33 UTC
Wrong bug... sorry for changes.