The acq histsearch page displays invoice numbers and allows their selection to retrieve shipments recorded against that invoice. Selection results in an error: Can't use an undefined value as an ARRAY reference at /home/koha/kohaclone/acqui/parcel.pl line 160. Cause of the error is that the the invoice id is passed as invoice whereas parcel.pl expects invoiceid so that GetInvoiceDetails is incorrectly called and returns undef rather than an invoice structure
Created attachment 14913 [details] [review] Proposed patch Testing: Without this patch applied selecting an invoicenumber from the acqui/histsearch screen results in a system error. With it applied a listing of related orders should be displayed
Created attachment 14919 [details] [review] Bug 9503 Correct name of parameter passed to parcel.pl invoiceid was being passed as invoice causing GetInvoiceDetails to silently fail and a system error downstream when accessing the 'orders' element of the undefined invoice Added an error message if GetInvoiceDetails called on undef Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 14920 [details] [review] Bug 9503 Correct name of parameter passed to parcel.pl invoiceid was being passed as invoice causing GetInvoiceDetails to silently fail and a system error downstream when accessing the 'orders' element of the undefined invoice Added an error message if GetInvoiceDetails called on undef Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 14973 [details] [review] Bug 9503: Followup Correct name of parameter passed to parcel.pl The booksellerid and datereceive parameters are useless.
Hi Colin and Galen, In fact 2 parameters (booksellerid and datereceived) are useless. They are not used by the histsearch.pl script. Could one of you sign off this patch please?
Created attachment 14981 [details] [review] Follow up patch signed off Signed off Changed the commit line to more accurately indicate what patch changed
Thanks Colin. Marked as Passed QA.
Created attachment 14992 [details] [review] Bug 9503 Correct name of parameter passed to parcel.pl invoiceid was being passed as invoice causing GetInvoiceDetails to silently fail and a system error downstream when accessing the 'orders' element of the undefined invoice Added an error message if GetInvoiceDetails called on undef Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 14993 [details] [review] Bug 9503: Followup remove unused parameters passed to parcel.pl The booksellerid and datereceive parameters are useless. Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
How do I get to the histsearch page? I can't seem to find it.
(In reply to comment #10) > How do I get to the histsearch page? I can't seem to find it. From the acquisition home page, select the "Orders search" tab (in the header) and click on the submit button (or the "advanced search" link).
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.3