batchMod.pl does not ensure each barcode is unique. This means that if a barcode is list twice, the actions are applied to it twice. This is not a problem, unless the modification is to batch delete items, in which case the batch deletion fails at the first duplicate barcode.
Created attachment 14960 [details] [review] Bug 9509 - batchMod.pl does not ensure each barcode is unique Test plan: 1) Browse to Tools › Batch item deletion 2) Enter a list of barcodes, make sure you have at least one barcode listed more than once 3) Click continue 4) Verify the duplicated barcode shows up multiple times in the table 5) Apply patch 6) Refresh the page 7) Verify each barcode now displays only once
Created attachment 15020 [details] [review] Bug 9509 - batchMod.pl does not ensure each barcode is unique Test plan: 1) Browse to Tools › Batch item deletion 2) Enter a list of barcodes, make sure you have at least one barcode listed more than once 3) Click continue 4) Verify the duplicated barcode shows up multiple times in the table 5) Apply patch 6) Refresh the page 7) Verify each barcode now displays only once Signed-off-by: Liz Rea <liz@catalyst.net.nz> verified bug and fix - both good. Nice test plan, thanks!
QA comment: Simple patch, works as expected. It removes duplicated barcodes. Marked as Passed QA.
Created attachment 15049 [details] [review] Bug 9509 - batchMod.pl does not ensure each barcode is unique Test plan: 1) Browse to Tools › Batch item deletion 2) Enter a list of barcodes, make sure you have at least one barcode listed more than once 3) Click continue 4) Verify the duplicated barcode shows up multiple times in the table 5) Apply patch 6) Refresh the page 7) Verify each barcode now displays only once Signed-off-by: Liz Rea <liz@catalyst.net.nz> verified bug and fix - both good. Nice test plan, thanks! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
I'm not seeing this commit in master, am I just being impatient?
(In reply to comment #6) > I'm not seeing this commit in master, am I just being impatient? I will be pushing master shortly.
Pushed to 3.8.x and 3.10.x will be in 3.8.10 and 3.10.3