The patron statistics page in circulation does not follow the styling of the rest of the pages, and doesn't include the circ/member toolbar. It needs to come into line with the rest of the interface.
Created attachment 14988 [details] [review] Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above.
Created attachment 14989 [details] [review] [SIGNED-OFF] Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Wouldn't be better with centered cell contents?
Thanks Owen of your patch. QA comment: This patch improves the ergonomic of the statistics patron page according to the others patron pages. Marked as Passed QA.
Created attachment 14995 [details] [review] Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Wouldn't be better with centered cell contents? Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> FIX a typo: - <h3>Statistcs for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3> + <h3>Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3>
This patch has been pushed to master.