Bug 9546 - MANIFEST.SKIP breaking regexp when running make manifest tardist
Summary: MANIFEST.SKIP breaking regexp when running make manifest tardist
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 03:59 UTC by Chris Cormack
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9546 : Updating make manifest tardist (694 bytes, patch)
2013-02-05 04:01 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9546 : Updating make manifest tardist (811 bytes, patch)
2013-02-05 04:45 UTC, Mason James
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9546 : Updating make manifest tardist (899 bytes, patch)
2013-02-05 22:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2013-02-05 03:59:35 UTC

    
Comment 1 Chris Cormack 2013-02-05 04:01:21 UTC Comment hidden (obsolete)
Comment 2 Mason James 2013-02-05 04:45:44 UTC Comment hidden (obsolete)
Comment 3 Mason James 2013-02-05 04:47:23 UTC
> Signed-off-by: Mason James <mtj@kohaaloha.com>

just tested this patch, works as expected :)
Comment 4 Katrin Fischer 2013-02-05 22:18:07 UTC
Created attachment 15081 [details] [review]
[SIGNED-OFF] Bug 9546 : Updating make manifest tardist

To test
perl Makefile.PL
make manifest tardist

Before the patch you will get an error, after the patch it will create
the tarball

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
make manifest tardist and make manifest zipdist work
perfectly after patch was applied.
Comment 5 Jared Camins-Esakov 2013-02-07 04:55:02 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2013-02-08 23:33:48 UTC
Pushed to 3.10.x and 3.8.x will be 3.10.3 and 3.8.10