Currently, you can use "lt,le,eq,ge" in your CCL query to handle "lesser than, lesser or equal to, equal to, greater than or equal to" relationships. The only one missing is "gt" (Bib1 2=5). The mappings are also off "ne, phonetic, stem", but those are Bib1 attributes that Zebra doesn't support, so that's not really relevant.
Created attachment 15082 [details] [review] Bug 9552 - BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties Currently, you can use "lt,le,eq,ge" in your CCL query to handle "lesser than, lesser or equal to, equal to, greater than or equal to" relationships. The only one missing is "gt" (Bib1 2=5). The mappings are also off "ne, phonetic, stem", but those are Bib1 attributes that Zebra doesn't support, so that's not really relevant. --- To test: Before applying patch... 1) On the OPAC or Intranet search bar, type in the following: pqf=@attr 1=32 @attr 2=5 "2009" (feel free to substitute any other number in for 2009 or any other phrase Use attribute you like which contains a number that can be compared - for instance, 31, which is pubdate) 2) Now, type in the following: acqdate,gt:2009 or ccl=acqdate,gt:2009 3) You'll notice that you get "No results found!", even though it should be the exact same query! 4) Apply patch 5) Re-try steps 1 and 2 6) Notice that your results will be identical for both the pqf and ccl queries. (Another note: This test will only work if you have items in your database that have dateaccessioned information that has been mapped to the 952$d field. If the test fails, try @attr 1=31 in step 1 and pubdate,gt in step 2) ---- This is a very simple patch that adds a correct mapping for "greater than" relationships. As far as I can tell, using the actual <, <=, >, >= signs don't actually work in search queries, so we should probably include the reference to "lt,le,gt,ge" in the Koha documentation.
Created attachment 15086 [details] [review] Bug 9552 - BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties Currently, you can use "lt,le,eq,ge" in your CCL query to handle "lesser than, lesser or equal to, equal to, greater than or equal to" relationships. The only one missing is "gt" (Bib1 2=5). The mappings are also off "ne, phonetic, stem", but those are Bib1 attributes that Zebra doesn't support, so that's not really relevant. To test: [1] Before applying the patch, try the following query in the OPAC: pubdate,gt:2006 You should get "no results found". [2] After applying the patch (and note that ccl.properties will usually need to be installed in the run-time Zebra configuration directory), try the same search. This time, you could get back the titles whose publication date is after 2006. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
QA comment: Good catch David! The patch works great and fixes 4 ccl relation values : gt, ne, stem and phonetic (http://www.indexdata.com/zebra/doc/querymodel-rpn.html) Marked as Passed QA.
Created attachment 15094 [details] [review] Bug 9552 - BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties Currently, you can use "lt,le,eq,ge" in your CCL query to handle "lesser than, lesser or equal to, equal to, greater than or equal to" relationships. The only one missing is "gt" (Bib1 2=5). The mappings are also off "ne, phonetic, stem", but those are Bib1 attributes that Zebra doesn't support, so that's not really relevant. To test: [1] Before applying the patch, try the following query in the OPAC: pubdate,gt:2006 You should get "no results found". [2] After applying the patch (and note that ccl.properties will usually need to be installed in the run-time Zebra configuration directory), try the same search. This time, you could get back the titles whose publication date is after 2006. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10,x and 3.8.x will be in 3.10.3 and 3.8.10
It's worth pointing out that many of these Bib-1 Relation Attributes won't work for you if you're using ICU indexing. Apparently, there is due to a known bug in Zebra. For more details, consult the following link: http://lists.indexdata.dk/pipermail/zebralist/2009-April/002190.html