Created attachment 15107 [details] [review] Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC.
Created attachment 15176 [details] [review] Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 15525 [details] [review] Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
rebased patch.
*** Bug 9714 has been marked as a duplicate of this bug. ***
*** Bug 9713 has been marked as a duplicate of this bug. ***
Created attachment 15720 [details] [review] [PASSED QA] Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, also checked calendar still works.
This patch has been pushed to master.
Created attachment 15963 [details] [review] Bug 9555: Another template contains single quotes in a js string
Created attachment 15988 [details] [review] Bug 9555: Another template contains single quotes in a js string Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment: The xt/single_quotes.t test failed before this patch # Failed test 'Files do not contain single quotes _(' ' # at xt/single_quotes.t line 39. # Files list: # manage.tt: return GB_showCenter(_('Export patron cards'), "/cgi-bin/koha/patroncards/print.pl?" + getstr, 700, 800); # Looks like you failed 1 test of 1. xt/single_quotes.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Now all tests pass. Marked as Passed QA.
Created attachment 16015 [details] [review] Bug 9555: Another template contains single quotes in a js string Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to 3.10.x will be in 3.10.6