If EnhancedMessagingPreferences is enabled, changing the patron category in the patron editor should change the messaging preferences that are assigned to the category defaults. However, this works only incompletely; numeric drop-downs are changed, but checkboxes are not. This is a result of one of the patches for bug 5462, which changed some HTML IDs without also updating the JavaScript that uses them.
Created attachment 15110 [details] [review] bug 9556: fix setting messaging prefs when changing patron category As a result of accumulated changes to field names returned by the members/default_messageprefs.pl service, the JavaScript to change the patron messaging preferences to the category default when changing a patron's category in the patron editor stopped working. To test: [1] Turn on the EnhancedMessagingPreferences feature. [2] Set message preference defaults for at least two patron categories. [3] Before applying the patch, create a new patron record using one of the categories you set prefs for, then change the category, then change it back again. You will see that numeric settings like the number of days for advanced notices will change, but checkboxes won't change. [4] Apply the patch, then create a new patron record and try changing the patron category. You will see that all of the preferences will get updated to the category default each time you change the category. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Testing note: this patch assumes that the patch for bug 9529 is applied.
Created attachment 15112 [details] [review] [SIGNED-OFF] Bug 9556: fix setting messaging prefs when changing patron category As a result of accumulated changes to field names returned by the members/default_messageprefs.pl service, the JavaScript to change the patron messaging preferences to the category default when changing a patron's category in the patron editor stopped working. To test: [1] Turn on the EnhancedMessagingPreferences feature. [2] Set message preference defaults for at least two patron categories. [3] Before applying the patch, create a new patron record using one of the categories you set prefs for, then change the category, then change it back again. You will see that numeric settings like the number of days for advanced notices will change, but checkboxes won't change. [4] Apply the patch, then create a new patron record and try changing the patron category. You will see that all of the preferences will get updated to the category default each time you change the category. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment: This patch fixes the described issue. Simple patch. Marked as Passed QA.
Created attachment 15134 [details] [review] Bug 9556: fix setting messaging prefs when changing patron category As a result of accumulated changes to field names returned by the members/default_messageprefs.pl service, the JavaScript to change the patron messaging preferences to the category default when changing a patron's category in the patron editor stopped working. To test: [1] Turn on the EnhancedMessagingPreferences feature. [2] Set message preference defaults for at least two patron categories. [3] Before applying the patch, create a new patron record using one of the categories you set prefs for, then change the category, then change it back again. You will see that numeric settings like the number of days for advanced notices will change, but checkboxes won't change. [4] Apply the patch, then create a new patron record and try changing the patron category. You will see that all of the preferences will get updated to the category default each time you change the category. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.6