Bug 9560 - Add a filter by basketgroup in reception page
Summary: Add a filter by basketgroup in reception page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Mathieu Saby
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 17:23 UTC by Mathieu Saby
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9560: Add a filter by basketgroup number in receipt page (5.11 KB, patch)
2013-03-09 17:57 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH][Revised] Bug 7593: Move orders on the destination record when merging 2 records (1.68 KB, patch)
2013-03-18 20:02 UTC, Mathieu Saby
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-02-06 17:23:04 UTC
In Receipt summary page, there are filters on the left : 
- isbn, author, title
- basket
- orderline
- ean

It would be useful to add a filter by basketgroup number.

Additionnaly, "basket" could be rename "basket number", and "ean" could be moved just behind "isbn, author, title"

M. Saby
Rennes 2 university
Comment 1 Mathieu Saby 2013-03-09 17:57:12 UTC
Created attachment 16001 [details] [review]
Bug 9560: Add a filter by basketgroup number in receipt page

Currently, it is not possible to filter received items using basketgroup number. For libraries using basketgroup, this could be an interesting feature.
This patch add a filter by basketgroup number in receipt page.
Additionally,
it renames "basket" filter into more explicit "basket number" (before, librarians could think the filter take into account basket name),
and it move EAN filter (visible only in unimarc flavor) in 2d position.

to test:
1. create a basket with some orders
2. close it and put in a basketgroup. Note the number of the basketgroup.
3. try the old and the new filters in reception page

M. Saby
Comment 2 Mathieu Saby 2013-03-09 17:58:30 UTC
I will make later an other patch for making basketgroups number visibles in the table listing all the received documents.

M. Saby
Comment 3 cedric.vita 2013-03-18 11:32:26 UTC
Le patch s'applique correctement et fonctionne. Il y a un problème tout de même sur l'affichage dans les bordereaux / Modification

http://pro.test1.biblibre.com/cgi-bin/koha/acqui/basketgroup.pl?op=add&booksellerid=2&basketgroupid=1

Le bouton "Enregistrer" en bas n'est pas visible (masqué par la barre de changement de langue)
Comment 4 Mathieu Saby 2013-03-18 11:34:42 UTC
Bonjour
The problem is probably not linked to the patch. I noticed it on other pages.
If you are in Marseille, could you ask somebody's else opinion ?

M. Saby
Comment 5 Mathieu Saby 2013-03-18 20:02:33 UTC Comment hidden (obsolete)
Comment 6 Mathieu Saby 2013-03-18 20:38:31 UTC
Ahhh, file attached to the wrong bug!
Comment 7 Mathieu Saby 2013-03-18 20:40:45 UTC
Comment on attachment 16001 [details] [review]
Bug 9560: Add a filter by basketgroup number in receipt page

attachement deleted by mistake...
M. Saby
Comment 8 Corinne BULAC 2013-03-20 09:50:59 UTC
filters work only if you receipt one item. Before reception, it's not possible to find somethin using filters.

Other question : is it normal than this filters work only for the supplier which has been choosen ? No possibility to find all the basket begging by a certain basket groupe name, basket number (for exemple : BULAC-2013) ?
Comment 9 Mathieu Saby 2013-03-21 21:04:02 UTC
For the 1st problem, I can not reproduce.

For the 2d point, the behavior is the same for baskets. It is logical, as you are not supposed to receive orders from vendors other than the one you choose when you begin to receive.

Could you retest and confirm the 1st problem ?

Mathieu Saby
Comment 10 Pierre Angot 2013-05-23 09:52:27 UTC
It will be a good idea to remplace "Basketgroup number" with basketgroup name ?
Comment 11 Mathieu Saby 2013-05-23 09:55:33 UTC
In Rennes 2, we search basketgroup by number, so it is usefull for us.
But I could keep basketgroup number and add an other filter for basketgroup name.

Mathieu
Comment 12 Mathieu Saby 2013-05-23 09:57:34 UTC
Rather that signing this patch, you should better sign this one

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124

I will "reactivate" 9560 after 10124 is pushed.

Mathieu
Comment 13 Mathieu Saby 2013-12-23 20:29:21 UTC
an other patch added a filter by basketgroup