Bug 9563 - Author links don't generate correct search query url for UseAuthoritesForTracings
Summary: Author links don't generate correct search query url for UseAuthoritesForTrac...
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 03:17 UTC by wajasu
Modified: 2023-06-08 22:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
intranet-tmpl-xslt_querydiff1.png grep -Hn 'q=au' and q=an (184.88 KB, image/png)
2013-02-07 04:44 UTC, wajasu
Details
intranet-tmpl-TT_querydiff1.png grep -Hn 'q=au' and q=an (25.88 KB, text/plain)
2013-02-07 04:46 UTC, wajasu
Details
opac-tmpl-xslt_querydiff.png grep -Hn 'q=au' and q=an (100.05 KB, text/plain)
2013-02-07 04:47 UTC, wajasu
Details
opac-tmpl-TT_querydiff2.png grep -Hn 'q=au' and q=an (62.67 KB, text/plain)
2013-02-07 05:11 UTC, wajasu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description wajasu 2013-02-07 03:17:05 UTC
The XSLT details, and possibly other places, change the generated author links ("By Joe Cool") to use the RLIN authorities for a key.  This happens when UseAuthoritesForTracings is enabled.

Problem: The template toolkit details.tt and possibly others, don't change the generated links just as the XSLT views do.

Search for UseAuthoritesForTracings inthe XSLT templates to see how they should be generated.

I don't know what the best way to dynamically change a generated link in our templates.  Maybe a centralized URL generator/map that we can refer to in the templates, which would respect sysprefs.  Or an INClude or function.  Either way, it would be nice to get some wiki pages describing TT and our strategy on dynamic template fragments.
Comment 1 wajasu 2013-02-07 04:44:44 UTC
Created attachment 15123 [details]
intranet-tmpl-xslt_querydiff1.png  grep -Hn 'q=au'   and q=an
Comment 2 wajasu 2013-02-07 04:46:01 UTC
Created attachment 15124 [details]
intranet-tmpl-TT_querydiff1.png  grep -Hn 'q=au'   and q=an
Comment 3 wajasu 2013-02-07 04:47:09 UTC
Created attachment 15125 [details]
opac-tmpl-xslt_querydiff.png   grep -Hn 'q=au'   and q=an
Comment 4 wajasu 2013-02-07 05:11:01 UTC
Created attachment 15126 [details]
opac-tmpl-TT_querydiff2.png   grep -Hn 'q=au'   and q=an

I've added some grep -Hn screenshots to show files that specify q=au and q=an  in their template logic for both XSLT and TT views.

It would probably be best to enumerate a more defined goal for this bug as I can see this becoming an omnibus bug.

Current goal: Get authors TT links to mirror the current XSLT link generation for both opac, and intranet.

The best way to test an authorlink in a view:
- With a known biblio with an $9 RLIN link to a valid authority:
- With UseAuthoritiesForTracings enabled
- With XSLT views on for results and details, hover over the Author link(s) and observe in the browser the URL that you would be directed to.
- It should contain something like: /cgi-bin/koha/opac-search.pl?q=an:359
(Without UseAuthorities it will have ?q=au:Joe Cool instead with an author name)
- Now turn off XSLT related views in sysprefs and navigate to the same views, and observe ?q=au: (when UseAuthoritiesForTracings is enabled.  This is the bug. It should be ?q=an:   with the correct authid as well.

The greps highlight possible other anomalies, but this bug can concentrate on the details and possibly results views for both opac and intranet.
Comment 5 Owen Leonard 2020-06-04 20:39:00 UTC
Do I understand correctly that this bug relates only to the non-XSLT views? With those in a long slow decline into deprecation should this bug be "WONTFIX?"