It would be nice if the items lost report had downloadable results.
The BULAC (http://www.bulac.fr/) would like to sponsore this development with the following features. On the form page : - add a new filter option on the “items.notforloan” field On the result page : - items can be selected - there are options “Activate / Deactivate filters”, “Select all” and “Clear all” (like on the “Holdings” tab on the bibliographic record) - a column display the “items.itemlost_on” timestamp - selected items can be exported ; different csv profiles can be chosen, based on the existing “CSV profiles” on the “Tools” menu As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>.
Created attachment 68085 [details] [review] Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool.
Created attachment 68086 [details] [review] Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste.
Created attachment 68087 [details] [review] Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later)
Created attachment 68088 [details] [review] Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table
Created attachment 68089 [details] [review] Bug 9573: Lost items report - Add a new "Export selected items" link
Created attachment 68090 [details] [review] Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far).
The patch appears to break the list of checkouts in the patron account: Error: Syntax error, unrecognized expression: ##issues-table
Created attachment 68184 [details] [review] Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost
(In reply to Katrin Fischer from comment #8) > The patch appears to break the list of checkouts in the patron account: > > Error: Syntax error, unrecognized expression: ##issues-table Indeed, I git grepped on **/*.tt but there was an occurrence in a .js file. Thanks for the catch!
Everyting work well (set csv profile, filter the list on notforloen ou itemlost, select items) until I try to export the selected items. I always get this Software error : Can't locate object method "new" via package "Text::CSV_XS" (perhaps you forgot to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line 68. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error.
Created attachment 68283 [details] [review] Bug 9573: Add missing use statement
(In reply to Séverine Queune from comment #11) > Everyting work well (set csv profile, filter the list on notforloen ou > itemlost, select items) until I try to export the selected items. > I always get this Software error : > Can't locate object method "new" via package "Text::CSV_XS" (perhaps you > forgot to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line > 68. > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error. I did not recreate with my perl version, but indeed there was a missing use statement.
(In reply to Jonathan Druart from comment #13) > (In reply to Séverine Queune from comment #11) > > Everyting work well (set csv profile, filter the list on notforloen ou > > itemlost, select items) until I try to export the selected items. > > I always get this Software error : > > Can't locate object method "new" via package "Text::CSV_XS" (perhaps you > > forgot to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line > > 68. > > For help, please send mail to the webmaster ([no address given]), giving > > this error message and the time and date of the error. > > I did not recreate with my perl version, but indeed there was a missing use > statement. I first tried at home with my personal laptop when I had this message. I just tried : - my professional computer + BULAC wired connexion : it works - my personal laptop + BULAC wifi for guests : it works I'll try again tonight with home wifi + laptop and will sign the patch if everything is ok.
Maybe you are just missing a dependency on the one computer?
Is Text::CSV (0.01) listed on your about page?
Created attachment 68351 [details] [review] Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68352 [details] [review] Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68353 [details] [review] Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68354 [details] [review] Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68355 [details] [review] Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68356 [details] [review] Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68357 [details] [review] Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 68358 [details] [review] Bug 9573: Add missing use statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
In my tests all works nicely now, I am filing a separate bug report for adding a sample CSV profile to make it a bit easier. Also, we already have one for claiming issues: bug 19507
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68398 [details] [review] Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68399 [details] [review] Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68400 [details] [review] Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68401 [details] [review] Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68402 [details] [review] Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68403 [details] [review] Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68404 [details] [review] Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 68405 [details] [review] Bug 9573: Add missing use statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Patches no longer apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9573: Lost items report - Add items.notforloan as a filter Applying: Bug 9573: Lost items report - Move filters code to a separate js file Applying: Bug 9573: Lost items report - add KohaTable to itemlost fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9573: Lost items report - add KohaTable to itemlost The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9573-Lost-items-report---add-KohaTable-to-item-M_2w8X.patc
Created attachment 71275 [details] [review] Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71276 [details] [review] Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71277 [details] [review] Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71278 [details] [review] Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71279 [details] [review] Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71280 [details] [review] Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71281 [details] [review] Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71282 [details] [review] Bug 9573: Add missing use statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Hi Jonathan, there are some conflicts about the new VERSION variable for .js files. I've tried to resolve those, but get tons of errors in the QA scripts. Can you please take a look? I will paste some examples below: FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/sco/help.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 13) FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/opac-user.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 742) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 719) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 862) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 46) OK git manipulation FAIL spelling transfered ==> transferred FAIL valid (Missing operator before shelfbrowser?) String found where operator expected syntax error (Missing operator before 'shelfbrowser.inc'?) koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/shelfbrowser.tt had compilation errors. Bareword found where operator expected Unquoted string "shelfbrowser" may clash with future reserved word FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt FAIL critic Code before strictures are enabled at line 1, column 1. See page 429 of PBP. OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Bareword found where operator expected (Missing operator before 'doc-head-open.inc'?) (Missing operator before 'doc-head-close.inc'?) koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt had compilation errors. Unquoted string "render" may clash with future reserved word (Missing semicolon on previous line?) (Missing operator before suggestion?) (Missing operator before divider?) syntax error Unquoted string "label" may clash with future reserved word (Missing operator before Koha?) (Missing operator before jsinclude?) Unquoted string "html" may clash with future reserved word (Missing operator before 'opac-bottom.inc'?) Unknown regexp modifier "/v" Unquoted string "divider" may clash with future reserved word String found where operator expected Unquoted string "opac" may clash with future reserved word Unknown regexp modifier "/n" Unquoted string "jsinclude" may clash with future reserved word Unquoted string "suggestions" may clash with future reserved word Unquoted string "cssinclude" may clash with future reserved word Unquoted string "koha" may clash with future reserved word Unquoted string "title" may clash with future reserved word (Missing operator before cssinclude?) Unquoted string "pl" may clash with future reserved word
Created attachment 71872 [details] [review] Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71873 [details] [review] Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71874 [details] [review] Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71875 [details] [review] Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71876 [details] [review] Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71877 [details] [review] Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71878 [details] [review] Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71879 [details] [review] Bug 9573: Add missing use statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 71880 [details] [review] Bug 9573: Add missing KOHA_VERSION in js paths
Katrin, You should double check your branch, you get errors on gb-GB files, they are not supposed to be committed (and so checked by the tests). I have rebased and added a patch to add the KOHA_VERSION part.
Argh, you are right... I had installed those and forgot to clean up. Will retest.
Much better, but one error remains: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template options_for_libraries: not found Maybe accidental removal of the include line? Will continue testing later.
Created attachment 71887 [details] [review] Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71888 [details] [review] Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71889 [details] [review] Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71890 [details] [review] Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71891 [details] [review] Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71892 [details] [review] Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71893 [details] [review] Bug 9573: Add missing use statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71894 [details] [review] Bug 9573: Add missing KOHA_VERSION in js paths Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71895 [details] [review] Bug 9573: (QA follow-up) Add missing include back Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I realized (while testing) that I did the original sign-off here. But as we have a second sign-off I hope the RM will be happy to have me QA as well.
Pushed to master for 18.05, thanks to everybody involved!