Bug 9576 - Enable or disable issue limit confirmation
Summary: Enable or disable issue limit confirmation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-09 04:12 UTC by vimal kumar
Modified: 2014-12-07 20:02 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9576 - Enable or disable issue limit confirmation (5.40 KB, patch)
2013-02-11 13:30 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9576 - Enable or disable issue limit confirmation (5.56 KB, patch)
2013-03-18 15:56 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 9576 - Enable or disable issue limit confirmation (5.45 KB, patch)
2013-06-05 07:49 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9576 - Enable or disable issue limit confirmation (5.50 KB, patch)
2013-06-07 06:51 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[PASSED QA] Bug 9576 - Enable or disable issue limit confirmation (5.99 KB, patch)
2013-07-12 22:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 9576 - Enable or disable issue limit confirmation (5.99 KB, patch)
2013-07-12 22:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description vimal kumar 2013-02-09 04:12:12 UTC
The limit of books for a student is three' When a book wants to get issued more it gives a message yes or no. If we say yes it allows us to issue. Its nice, if we can disable this provision using a system preference.
Comment 1 Kyle M Hall 2013-02-11 13:12:36 UTC
This should be controlled via a syspref ala the Allow*Override system preferences.
Comment 2 Kyle M Hall 2013-02-11 13:30:25 UTC Comment hidden (obsolete)
Comment 3 Fridolin Somers 2013-03-18 15:56:44 UTC Comment hidden (obsolete)
Comment 4 Koha Team University Lyon 3 2013-03-18 16:28:51 UTC
OK : if syspref "AllowTooManyOverride" is don't allow : there's an alert and you can't borrow more than the limit.

if if syspref "AllowTooManyOverride" is allow : there's a question and you can choose to borrow
Comment 5 Chris Cormack 2013-06-03 10:29:43 UTC
Did you miss adding your sign off to this patch?
Comment 6 Koha Team University Lyon 3 2013-06-04 09:17:22 UTC
Yes, I completely forgot, sorry.
And now the patch doesn't apply any more...
Comment 7 Fridolin Somers 2013-06-05 07:49:10 UTC Comment hidden (obsolete)
Comment 8 Srdjan Jankovic 2013-06-07 06:51:06 UTC Comment hidden (obsolete)
Comment 9 Galen Charlton 2013-06-07 18:43:00 UTC
(In reply to comment #1)
> This should be controlled via a syspref ala the Allow*Override system
> preferences.

This comment isn't about the proposed patch per se, just inspired by it.

Doing it via syspref, while consistent with precedent (OverduesBlockCirc, AllFinesNeedOverride,  AllowNotForLoanOverride, AgeRestrictionOverride, etc.), bothers me.  The ability to override isn't necessarily just a matter of library policy; it also ought to be a matter of staff permission.

The problem with using sysprefs is that they're too broad.  As the original bug reporter implies, you don't necessarily want ordinary circ clerks to be able to override the limit, but you probably do want circ supervisors to be able to do so; consider the usual "library board member is standing in front of you wanting to check out just one more book" scenario.

If we pursue creating staff user permissions for overrides, how do folks think they should work?  Replace the system preference?  Work in conjunction with the syspref?

As I said, this comment isn't about the proposed patch, which is consistent with how things have been handled in the past.
Comment 10 Katrin Fischer 2013-07-12 22:28:35 UTC
I will test this as it's a consistent change and I think Galen is ok with it? But I agree that we should start to think about how to handle these on permission level.

I think AllowRenewalLimitOverride works in combination with a permission, but I am not sure what takes precedence. - Should it be possible to overwrite the global setting with the permission? Should the permission only be offered, when the system preference allows the action in general?
Comment 11 Katrin Fischer 2013-07-12 22:51:33 UTC Comment hidden (obsolete)
Comment 12 Katrin Fischer 2013-07-12 22:52:00 UTC
Created attachment 19613 [details] [review]
[PASSED QA] Bug 9576 - Enable or disable issue limit confirmation

Adds a new system preference AllowTooManyOverride to control whether
a librarian can override the 'Too many checked out' message which is
currently always overridable.

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Attempt to check out 1 more item to a patron than the max issues
4) You should be allowed to override by default ( current behavior )
5) Set AllowTooManyOverride to "Don't allow"
6) Repeat step 3
7) You should be blocked from being able to issue the item

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

The new system preference is activated by default, which mean there
will be know change in behaviour on update.

The system preference is correctly added to the database and .pref
files.

Test plan and QA script passes.
Comment 13 Galen Charlton 2013-07-17 15:30:30 UTC
Pushed to master.  Thanks, Kyle!