The limit of books for a student is three' When a book wants to get issued more it gives a message yes or no. If we say yes it allows us to issue. Its nice, if we can disable this provision using a system preference.
This should be controlled via a syspref ala the Allow*Override system preferences.
Created attachment 15236 [details] [review] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item
Created attachment 16272 [details] [review] Bug 9576 - Enable or disable issue limit confirmation Patch rebased master
OK : if syspref "AllowTooManyOverride" is don't allow : there's an alert and you can't borrow more than the limit. if if syspref "AllowTooManyOverride" is allow : there's a question and you can choose to borrow
Did you miss adding your sign off to this patch?
Yes, I completely forgot, sorry. And now the patch doesn't apply any more...
Created attachment 18658 [details] [review] Bug 9576 - Enable or disable issue limit confirmation Rebased master.
Created attachment 18722 [details] [review] [SIGNED-OFF] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
(In reply to comment #1) > This should be controlled via a syspref ala the Allow*Override system > preferences. This comment isn't about the proposed patch per se, just inspired by it. Doing it via syspref, while consistent with precedent (OverduesBlockCirc, AllFinesNeedOverride, AllowNotForLoanOverride, AgeRestrictionOverride, etc.), bothers me. The ability to override isn't necessarily just a matter of library policy; it also ought to be a matter of staff permission. The problem with using sysprefs is that they're too broad. As the original bug reporter implies, you don't necessarily want ordinary circ clerks to be able to override the limit, but you probably do want circ supervisors to be able to do so; consider the usual "library board member is standing in front of you wanting to check out just one more book" scenario. If we pursue creating staff user permissions for overrides, how do folks think they should work? Replace the system preference? Work in conjunction with the syspref? As I said, this comment isn't about the proposed patch, which is consistent with how things have been handled in the past.
I will test this as it's a consistent change and I think Galen is ok with it? But I agree that we should start to think about how to handle these on permission level. I think AllowRenewalLimitOverride works in combination with a permission, but I am not sure what takes precedence. - Should it be possible to overwrite the global setting with the permission? Should the permission only be offered, when the system preference allows the action in general?
Created attachment 19612 [details] [review] [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes.
Created attachment 19613 [details] [review] [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes.
Pushed to master. Thanks, Kyle!