Bug 9586 - Remove $ENV{DEBUG} info from Member Template
Summary: Remove $ENV{DEBUG} info from Member Template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Cook
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 05:42 UTC by David Cook
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9586 - Remove $ENV{DEBUG} info from Member Template (2.76 KB, patch)
2013-02-11 05:50 UTC, David Cook
Details | Diff | Splinter Review
Bug 9586 - Remove $ENV{DEBUG} info from Member Template (2.31 KB, patch)
2013-02-15 12:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9586 - Remove $ENV{DEBUG} info from Member Template (2.37 KB, patch)
2013-03-05 19:06 UTC, Elliott Davis
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-02-11 05:42:14 UTC
Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)".

While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s).

No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one.
Comment 1 David Cook 2013-02-11 05:50:57 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-02-15 12:22:17 UTC Comment hidden (obsolete)
Comment 3 Elliott Davis 2013-03-05 19:06:19 UTC
Created attachment 15894 [details] [review]
Bug 9586 - Remove $ENV{DEBUG} info from Member Template

Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)".

While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s).

No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Elliott Davis <elliott@bywatersolions.com>
Comment 4 Jared Camins-Esakov 2013-03-07 14:50:16 UTC
This patch has been pushed to master.
Comment 5 Chris Cormack 2013-03-11 09:46:13 UTC
Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4