Serious bug encountered. SET LIBRARY automatically changes after viewing Holds Queue report for another library and then clicking on a reserved item on patron record. See attached video. Video Link: http://media.bywatersolutions.com/Video/set_library_change_bug.mp4 Best Regards, -Jesse
Steps to reproduce: 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report.
I verify this as a problem, and it's a big one.
Working on a fix for this
Ah ha <input autocomplete="off" id="findborrower" name="findborrower" size="40" class="focus" type="text" /> <input id="autocsubmit" type="submit" class="submit" value="Submit" /> <input name="branch" value="AS" type="hidden" /> And we set branch => $branchlimit, Which is what we chose to limit on. However in koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc we set <input name="branch" value="[% branch %]" type="hidden" />
Created attachment 17274 [details] [review] Bug 9591 : Set Library changes after viewing Holds Queue >> reserves item To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch
Created attachment 17282 [details] [review] Bug 9591 : Set Library changes after viewing Holds Queue >> reserves item To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Weird bug, the patch works for me.
Created attachment 17322 [details] [review] [PASSED QA] Bug 9591 : Set Library changes after viewing Holds Queue >> reserves item To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Weird bug, the patch works for me. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch. All tests and QA script pass.
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13