In some XSLT, "items" namespace is used in exclude-result-prefixes but is not defined.
This bug generates in log : [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: compilation error: file /home/fsomers/workspace/versions/community_master/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl line 8 element stylesheet, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: xsl:exclude-result-prefixes : undefined namespace items, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299
Created attachment 15315 [details] [review] Proposed patch See commit message
Created attachment 15350 [details] [review] Bug 9613: items namespace missing in XSLT In some XSLT, "items" namespace is used in exclude-result-prefixes but is not defined. This patch add this namespace where missing. Also corrects a koha.org, instead of koha-community.org, in one namespace URL. Test plan : - Enable XSLT on search results - Perform a search => Look at error logs to check that there is no xsl error like : [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: compilation error: file koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl line 8 element stylesheet, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: xsl:exclude-result-prefixes : undefined namespace items, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 15439 [details] [review] [PASSED QA] Bug 9631 - Replace YUI buttons on classification sources administration page with Bootstrap This patch converts the toolbar on the class sources administration page to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the class sources administration page. Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Change "rules" to singular. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found.
Comment on attachment 15439 [details] [review] [PASSED QA] Bug 9631 - Replace YUI buttons on classification sources administration page with Bootstrap Sorry, typo in bugnumber.
QA Comment: I do not object to pushing this patch, but it seems that you could strip the lines with prefixes from Utils. This is a import file. Compare MARC21 file. Did not test this UNIMARC trivial patch. But will add a Passed QA line.
Created attachment 16897 [details] [review] Bug 9613: items namespace missing in XSLT In some XSLT, "items" namespace is used in exclude-result-prefixes but is not defined. This patch add this namespace where missing. Also corrects a koha.org, instead of koha-community.org, in one namespace URL. Test plan : - Enable XSLT on search results - Perform a search => Look at error logs to check that there is no xsl error like : [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: compilation error: file koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl line 8 element stylesheet, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: xsl:exclude-result-prefixes : undefined namespace items, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> With comment on Bugzilla.
I would like another sign off on this from someone who uses UNIMARC. Another BibLibre employee is fine. But since neither Marcel nor I can actually test this patch thanks to bug 3087, another sign off would be a good idea.
Without your patch, I have (among other warns about $ccode and $value...) List of results : [Fri Apr 12 15:55:56 2013] [error] [client 127.0.0.1] [Fri Apr 12 15:55:56 2013] opac-search.pl: compilation error: file /home/msaby/kohamaster/src/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl line 8 element stylesheet, referer: http://opac.koha-msaby/cgi-bin/koha/opac-search.pl?q=france [Fri Apr 12 15:55:56 2013] [error] [client 127.0.0.1] [Fri Apr 12 15:55:56 2013] opac-search.pl: xsl:exclude-result-prefixes : undefined namespace items, referer: http://opac.koha-msaby/cgi-bin/koha/opac-search.pl?q=france Singe record : [Fri Apr 12 15:57:44 2013] [error] [client 127.0.0.1] [Fri Apr 12 15:57:44 2013] opac-detail.pl: compilation error: file /home/msaby/kohamaster/src/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl line 8 element stylesheet [Fri Apr 12 15:57:44 2013] [error] [client 127.0.0.1] [Fri Apr 12 15:57:44 2013] opac-detail.pl: xsl:exclude-result-prefixes : undefined namespace items After applying your patch, these warns disappear. Nothing else seems changed. I sign off. M. Saby
Created attachment 17391 [details] [review] [PATCH][SIGNED OFF] Bug 9613: items namespace missing in XSLT
(In reply to comment #9) > After applying your patch, these warns disappear. > Nothing else seems changed. > I sign off. > > M. Saby Back to Passed QA
Created attachment 17492 [details] [review] Bug 9613: items namespace missing in XSLT In some XSLT, "items" namespace is used in exclude-result-prefixes but is not defined. This patch add this namespace where missing. Also corrects a koha.org, instead of koha-community.org, in one namespace URL. Test plan : - Enable XSLT on search results - Perform a search => Look at error logs to check that there is no xsl error like : [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: compilation error: file koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl line 8 element stylesheet, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 [Fri Feb 08 15:35:06 2013] [error] [client 127.0.0.1] [Fri Feb 8 15:35:06 2013] opac-search.pl: xsl:exclude-result-prefixes : undefined namespace items, referer: http://opac.master.community.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> With comment on Bugzilla. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master and 3.12.x. I was unable to replicate the bug on my UNIMARC installation, but the change is logical and -- I think -- low risk, so I am pushing it anyway.
Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13