Bug 9619 - Replace YUI buttons on libraries administration page with Bootstrap
Summary: Replace YUI buttons on libraries administration page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/admin/branches.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 15:28 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9619 - Replace YUI buttons on libraries administration page with Bootstrap (2.27 KB, patch)
2013-02-15 15:31 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9619 - Replace YUI buttons on libraries administration page with Bootstrap (2.38 KB, patch)
2013-02-15 22:46 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 9619 - Replace YUI buttons on libraries administration page with Bootstrap (2.47 KB, patch)
2013-02-17 14:27 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 15:28:56 UTC 
The toolbar buttons on the libraries administration page are constructed using YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 15:31:33 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 22:46:49 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 14:27:54 UTC 
Created attachment 15468 [details] [review]
[PASSED QA] Bug 9619 - Replace YUI buttons on libraries administration page with Bootstrap

This patch converts the toolbar used by libraries administration
to Bootstrap, replacing YUI button and menu code
with Bootstrap markup.

To test, view any the branches administration page and confirm
that the buttons to add a library and add a category look
correct and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Both buttons, Library and Group, works and look well. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Jared Camins-Esakov 2013-02-18 13:03:31 UTC 
This patch has been pushed to master.