Bug 9623 - Replace YUI button on authority types administration page with Bootstrap
Summary: Replace YUI button on authority types administration page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/admin/authtypes.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 16:23 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9623 - Replace YUI button on authority types administration page with Bootstrap (1.72 KB, patch)
2013-02-15 16:25 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9623 - Replace YUI button on authority types administration page with Bootstrap (1.79 KB, patch)
2013-02-15 19:23 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9623 - Replace YUI button on authority types administration page with Bootstrap (1.88 KB, patch)
2013-02-17 12:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 16:23:50 UTC
The authority types administration page uses YUI to generate the "New authority type" button. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 16:25:46 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 17:22:33 UTC
Owen, for some strange reason this patch applies but do NOT change the file.
Pre and Post related bugs applied correctly, but this one refuses to work,
for me at last.

Maybe someone else has better luck :(
Comment 3 Bernardo Gonzalez Kriegel 2013-02-15 19:22:17 UTC
Ouch! My mistake. Was looking the wrong page. Sorry
Comment 4 Bernardo Gonzalez Kriegel 2013-02-15 19:23:50 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-02-17 12:10:13 UTC
Created attachment 15458 [details] [review]
[PASSED QA] Bug 9623 - Replace YUI button on authority types administration page with Bootstrap

This patch converts the toolbar on the authority types administration
page to to Bootstrap, replacing YUI button code with Bootstrap markup.

To test, view the authority types administration page and confirm that
the "New authority type" button looks correct and works correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 6 Jared Camins-Esakov 2013-02-18 13:07:26 UTC
This patch has been pushed to master.