Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap
Summary: Replace YUI button on reports dictionary page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/reports/dictionary.pl?p...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 16:34 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap (2.43 KB, patch)
2013-02-15 16:36 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap (2.50 KB, patch)
2013-02-15 17:08 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap (2.59 KB, patch)
2013-02-17 09:25 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 16:34:45 UTC 
The reports dictionary page uses YUI to generate the "New definition" button. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 16:36:07 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 17:08:51 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 09:25:59 UTC 
Created attachment 15445 [details] [review]
[PASSED QA] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap

This patch removes the toolbar include file used by the reports
dictionary and embeds the toolbar markup directly in the main
template since it's the only instance where it is used.
Toolbar is converted to use Bootstrap, replacing YUI button code
with Bootstrap markup.

To test, view the reports dictionary and confirm that the "New
definition" button looks correct and works correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Jared Camins-Esakov 2013-02-18 13:08:29 UTC 
This patch has been pushed to master.