Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap
Summary: Replace YUI buttons and menus on reports pages with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/reports/guided_reports.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 16:41 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap (4.13 KB, patch)
2013-02-15 16:45 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap (4.20 KB, patch)
2013-02-15 17:13 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap (4.37 KB, patch)
2013-02-17 14:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 16:41:10 UTC
The toolbar include file used by some reports pages uses YUI to generate buttons and menus. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 16:45:53 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 17:13:15 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 14:38:31 UTC
Created attachment 15469 [details] [review]
[PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap

This patch converts the toolbar include file used by guided/SQL report
pages to Bootstrap, replacing YUI button and menu code with Bootstrap
markup.

To test, view any page in reports/ which uses reports-toolbar.inc
(Saved reports, Guided reports, SQL reports). Buttons and menus should
look correct and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as described. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, logic is correct. Toolbar differes, depending
on the action: show report, list of reports, edit report.
Comment 4 Jared Camins-Esakov 2013-02-18 13:13:47 UTC
Is there a reason for the 'xx' in this line:
+[% IF ( showsql || execute || editsql || save_successful ) %]xx

If not -- and I don't think there is -- I will remove it prior to pushing.
Comment 5 Owen Leonard 2013-02-19 14:23:17 UTC
(In reply to comment #4)
> Is there a reason for the 'xx' in this line:
> +[% IF ( showsql || execute || editsql || save_successful ) %]xx
> 
> If not -- and I don't think there is -- I will remove it prior to pushing.

Thank you, you are correct.
Comment 6 Jared Camins-Esakov 2013-02-20 13:27:41 UTC
This patch has been pushed to master.