Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap
Summary: Replace YUI buttons and menus on serials pages with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/serials/serials-home.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 16:54 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap (8.49 KB, patch)
2013-02-15 16:57 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap (8.69 KB, patch)
2013-02-15 17:38 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap (9.04 KB, patch)
2013-02-17 09:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 16:54:24 UTC
The toolbar include file used by serials pages uses YUI to generate buttons and menus. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 16:57:20 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 17:38:06 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 09:40:21 UTC
Created attachment 15448 [details] [review]
[PASSED QA] Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap

This patch converts the toolbar include file used by Serials pages to
Bootstrap, replacing YUI button and menu code with Bootstrap markup.

To test, view any page in serials/ which uses serials-toolbar.inc
(subscription-detail.pl, serials-home.pl, etc).
Buttons and menus should look correct and work correctly, including:

- New subscription
- Edit subscription
- Edit as new (duplicate)
- Delete subscription
- Renew
- Receive
- Close

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
For me it would be better to use icon-remove, because icon-remove-circle
shows a little cross, think that a bigger cross is more clear.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
I think there is a point in differentiating between closing and deleting,
so the icon-remove-circle is maybe not ideal, but the icon-remove
would falsely indicate a delete. Maybe we can find another icon that
expresses the functionality a bit better later on.
Comment 4 Jared Camins-Esakov 2013-02-18 13:23:15 UTC
This patch has been pushed to master.