Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap
Summary: Replace YUI buttons on label batches pages with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/labels/label-edit-batch...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 18:10 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap (16.64 KB, patch)
2013-02-15 19:22 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap (16.79 KB, patch)
2013-02-15 19:57 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap (16.88 KB, patch)
2013-02-17 12:53 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 18:10:12 UTC 
The toolbar buttons on the label batch pages are generated using YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 19:22:33 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 19:57:25 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 12:53:25 UTC 
Created attachment 15464 [details] [review]
[PASSED QA] Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap

This patch converts the toolbar used by label batches pages to
Bootstrap, replacing YUI button and menu code with Bootstrap markup.

This patch also consolidates the include file and main template. The
include file was used in only one template.

To test, create a label batch and test all functions related to that
batch: adding and removing items, de-duplicating the batch, exporting
individual items, exporting the batch, and deleting the batch. Buttons
should look correct and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described, no errors.
Tested all functions (add, del, de-duplicate, export item, export batch)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Jared Camins-Esakov 2013-02-18 13:56:08 UTC 
This patch has been pushed to master.