Bug 9636 - Replace YUI buttons on labels pages with Bootstrap
Summary: Replace YUI buttons on labels pages with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/labels/label-home.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 19:29 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 9636 - Replace YUI buttons on labels pages with Bootstrap (5.82 KB, patch)
2013-02-15 19:33 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap (5.99 KB, patch)
2013-02-15 20:11 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap (6.16 KB, patch)
2013-02-17 11:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 19:29:48 UTC
The toolbar include file used on labels pages uses YUI to generate buttons and menus. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 19:33:44 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 20:11:26 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 11:54:01 UTC
Created attachment 15456 [details] [review]
[PASSED QA] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap

This patch converts the toolbar include file used by the label manager
to Bootstrap, replacing YUI button and menu code with Bootstrap markup.

This patch converts the previous menu buttons to plain buttons,
removing the redundant links to the manage pages, which are in the
left-hand sidebar. This keeps toolbar buttons within the general
category of "action" (as opposed to "view").

This patch also removes an unused include file, labels-new-toolbar.inc

To test, view the labels home page and any of the label manage pages
(layouts, templates, profiles, batches). Buttons should look correct
and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
Nicole is not going to be happy, images in Label creator section
of manual needs to change :)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, I was wondering if we should have the plus icon
on those buttons like we have on the other 'New' buttons.
Comment 4 Katrin Fischer 2013-02-17 11:55:01 UTC
I like the changes to the menu structure. My only question is, why the buttons don't have the plus icons like we have it on the other 'new' buttons.

No reason not to pass QA on this improvement tho :)
Comment 5 Jared Camins-Esakov 2013-02-18 13:57:44 UTC
This patch has been pushed to master.