Bug 9639 - Replace YUI button on MARC tag structure toolbar with Bootstrap
Summary: Replace YUI button on MARC tag structure toolbar with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/admin/marctagstructure....
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 19:54 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9639 - Replace YUI button on MARC tag structure toolbar with Bootstrap (1.82 KB, patch)
2013-02-15 19:57 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9639 - Replace YUI button on MARC tag structure toolbar with Bootstrap (1.92 KB, patch)
2013-02-15 20:25 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 9639 - Replace YUI button on MARC tag structure toolbar with Bootstrap (2.01 KB, patch)
2013-02-17 13:02 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 19:54:21 UTC 
The MARC tag structure toolbar button is generated by YUI. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 19:57:11 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 20:25:28 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 13:02:21 UTC 
Created attachment 15465 [details] [review]
[PASSED QA] Bug 9639 - Replace YUI button on MARC tag structure toolbar with Bootstrap

This patch converts the toolbar used on the MARC tag structure toolbar
to Bootstrap, replacing YUI button code with Bootstrap markup.

To test, view marctagstructure.pl for any framework. Confirm that the
'New tag' button looks correct and works correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Confirmed that 'New tag' looks and works correctly.
No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Jared Camins-Esakov 2013-02-18 14:03:41 UTC 
This patch has been pushed to master.