Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap
Summary: Replace YUI buttons on authorized values administration page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/admin/authorised_values.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-16 21:06 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap (2.85 KB, patch)
2013-02-16 21:12 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap (2.94 KB, patch)
2013-02-16 21:17 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap (3.03 KB, patch)
2013-02-17 15:03 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-16 21:06:20 UTC 
The toolbar buttons on the authorized values administration page are constructed using YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-16 21:12:44 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-16 21:17:41 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 15:03:59 UTC 
Created attachment 15473 [details] [review]
[PASSED QA] Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap

This patch converts the toolbar on the authorised values administration
page to to Bootstrap, replacing YUI button code with Bootstrap markup.

To test, view the authorised values administration page and confirm that
the "New authorized value..." and "New cateogry" buttons look correct
and works correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Both buttons works and look correctly. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Katrin Fischer 2013-02-17 15:04:31 UTC 
I wonder, if the buttons should be showing the plus icon?
Comment 5 Jared Camins-Esakov 2013-02-18 12:55:55 UTC 
This patch has been pushed to master.