Created attachment 15441 [details] screenshot To reproduce: 1) Create a budget 2) Create a fund for it 3) Click on delete link in list of funds 4) Check confirmation message says: Delete fund XXX? Delete this budget.
Created attachment 15466 [details] [review] Bug 9651 - When deleting a fund, button is wrongly labelled with 'Delete this budget' This patch change legends to approve/cancel deletion of a fund. Changed to Delete/Cancel, same messages to delete a Budget. To test: 1) When deleting a fund, confirmation messages said: 'Delete this budget XXX?' to approve 'No, do not delete' to cancel 2) Apply the patch 3) Now the messages are 'Delete'/'Cancel'
Created attachment 15489 [details] [review] [SIGNED-OFF] Bug 9651 - When deleting a fund, button is wrongly labelled with 'Delete this budget' This patch change legends to approve/cancel deletion of a fund. Changed to Delete/Cancel, same messages to delete a Budget. To test: 1) When deleting a fund, confirmation messages said: 'Delete this budget XXX?' to approve 'No, do not delete' to cancel 2) Apply the patch 3) Now the messages are 'Delete'/'Cancel' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly.
QA comment: Ergonomic improvement on deleting a fund (same as the confirmation message on deleting a budget). Marked as Passed QA.
Created attachment 15535 [details] [review] Bug 9651 - When deleting a fund, button is wrongly labelled with 'Delete this budget' This patch change legends to approve/cancel deletion of a fund. Changed to Delete/Cancel, same messages to delete a Budget. To test: 1) When deleting a fund, confirmation messages said: 'Delete this budget XXX?' to approve 'No, do not delete' to cancel 2) Apply the patch 3) Now the messages are 'Delete'/'Cancel' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4