Bug 9671 - fines.pl cronjob help lists wrong values for finesmode syspref
Summary: fines.pl cronjob help lists wrong values for finesmode syspref
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Aaron Wells
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 13:15 UTC by Jared Camins-Esakov
Modified: 2014-05-26 21:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
A patch to correct the fines.pl help text (1.05 KB, patch)
2013-03-25 04:01 UTC, Aaron Wells
Details | Diff | Splinter Review
Bug 9671: Make fines.pl help text more accurate (1.26 KB, patch)
2013-04-10 02:30 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 9671: Make fines.pl help text more accurate (1.34 KB, patch)
2013-04-12 16:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 9671: Make fines.pl help text more accurate (1.42 KB, patch)
2013-04-22 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-02-20 13:15:45 UTC
From misc/cronjobs/fines.pl -h: "If the Koha System Preference 'finesMode' is set to 'production', the fines are charged to the patron accounts.  If set to 'test', the fines are calculated but not applied."
In fact, finesMode can be set to either "Calculate (but only for mailing to the admin)" or "Calculate and charge."
Comment 1 Aaron Wells 2013-03-25 04:01:36 UTC Comment hidden (obsolete)
Comment 2 David Cook 2013-04-02 23:13:28 UTC
(In reply to comment #1)
> Created attachment 16843 [details] [review] [review]
> A patch to correct the fines.pl help text
> 
> Adding a patch to correct the fines.pl help text to match the options for
> finesMode

Personally, I'd rather sign off on a patch that includes the actual values ("Calculate (but only for mailing to the admin)", "Calculate and charge", and "Don't calculate") for the system preference along with an explanation rather than just the explanation.
Comment 3 Owen Leonard 2013-04-09 18:56:24 UTC
This patch lacks a commit message which describes the problem, describes the solution, and shows how to test.
Comment 4 Liz Rea 2013-04-10 02:30:40 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2013-04-10 02:31:11 UTC
Merely fixing up the commit message.
Comment 6 Kyle M Hall 2013-04-12 16:13:39 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2013-04-22 06:05:03 UTC
Just a note on this - the longer descriptions only make sense if you are using the English templates. The shorter versions would have worked for me too ;)
Comment 8 Katrin Fischer 2013-04-22 06:08:21 UTC
Created attachment 17571 [details] [review]
[PASSED QA] Bug 9671: Make fines.pl help text more accurate

To test:

run kohaclone/misc/cronjobs/fines.pl --help and note the help text. It should match the settings in System Preferences.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Documentation change, passes all tests.
Comment 9 Jared Camins-Esakov 2013-04-26 22:36:11 UTC
This patch has been pushed to master and 3.12.x.