The toolbar include file (acquisitions-toolbar.inc) used on several acquisitions pages (supplier.pl, booksellers.pl, etc.) uses YUI for buttons and button menus. It should use Bootstrap instead.
Created attachment 15639 [details] [review] Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders.
Created attachment 15640 [details] [review] [SIGNED-OFF] Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Buttons works. No errors. Tested vendors with and without orders (delete button in last case)
Created attachment 15827 [details] [review] [PASSED QA] Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Buttons works. No errors. Tested vendors with and without orders (delete button in last case) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, changes are consistent.
This patch has been pushed to master.
I look forward to another follow-up that adds Bootstrap on the basket groups page.