Bug 9677 - Style button on notices and slips page with Bootstrap
Summary: Style button on notices and slips page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL: /cgi-bin/koha/tools/letter.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 21:07 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9677 - Style button on notices and slips page with Bootstrap (2.03 KB, patch)
2014-02-20 14:50 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 9677 - Style button on notices and slips page with Bootstrap (2.17 KB, patch)
2014-02-20 17:24 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 9677 - Style button on notices and slips page with Bootstrap (2.27 KB, patch)
2014-02-21 11:34 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-20 21:07:40 UTC
The notices and slips page uses YUI to generate the "New notice" button. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-20 21:10:06 UTC
Okay, so I guess there's not actually any YUI to replace, but the button can be converted to Bootstrap anyway.
Comment 2 Owen Leonard 2014-02-20 14:50:07 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2014-02-20 17:24:15 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-02-21 11:34:21 UTC
Created attachment 25530 [details] [review]
Bug 9677 - Style button on notices and slips page with Bootstrap

The toolbar button on the Notices & Slips page isn't styled with
Bootstrap as other toolbar buttons are. This patch corrects this.

The patch also removes some obsolete CSS.

To test go to Tools -> Notices and Slips. The toolbar button should look
correct and work correctly.

Patch works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
"yui-menu-button" is not contained in tt files.
Comment 5 Galen Charlton 2014-02-21 18:29:35 UTC
Pushed to master.  Thanks, Owen!
Comment 6 Fridolin Somers 2014-06-03 13:39:32 UTC
Pushed to 3.14.x, will be in 3.14.08