Bug 9680 - cart aligned right in CCSR
Summary: cart aligned right in CCSR
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 21:26 UTC by Nicole C. Engard
Modified: 2013-12-05 20:09 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
cart in prog (134.92 KB, image/png)
2013-02-20 21:26 UTC, Nicole C. Engard
Details
cart in ccsr (130.73 KB, image/png)
2013-02-20 21:26 UTC, Nicole C. Engard
Details
Bug 9680 - cart aligned right in CCSR (4.64 KB, patch)
2013-05-10 16:20 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9680 - cart aligned right in CCSR (4.69 KB, patch)
2013-05-10 16:54 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 9680 - cart aligned right in CCSR (4.88 KB, patch)
2013-05-12 09:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-02-20 21:26:18 UTC
Created attachment 15576 [details]
cart in prog

When you're using CCSR the cart contents have a big margin on the left that's pushing them off screen.  Attached are images of the same cart in both themes - the window is the same size in both.
Comment 1 Nicole C. Engard 2013-02-20 21:26:51 UTC
Created attachment 15577 [details]
cart in ccsr

see how i have to make the window bigger to see the contents and there is an extra large margin on the left. It should be centered to the window like in PROG
Comment 2 Owen Leonard 2013-05-10 16:20:06 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2013-05-10 16:54:47 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-05-12 09:08:22 UTC
Created attachment 18088 [details] [review]
[PASSED QA] Bug 9680 - cart aligned right in CCSR

The CCSR theme sets a min-width of 1000px for windows which are more
than 700px wide. This caused the cart popup window to be given a
min-width of 1000px, resulting in a broken layout with unnecessary
horizontal scrolling.

This patch adds a class to the cart template and to other pop-up window
templates to ensure that a large min-width is not enforced and to give
consistent padding to those pages.

To test, set your theme to 'CCSR' and view the following pop-up pages:

- The Cart. From the cart, trigger:
  - The "send" window
  - The "download" window
- From a view of a List's contents trigger:
 - The "send" window"
 - The "download" window

Each of these pages should look correct with no horizontal scrolling.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template and CSS changes only, but no string changes.
Save for inclusion in 3.12.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 5 Jared Camins-Esakov 2013-05-12 14:15:04 UTC
This patch has been pushed to master and 3.12.x.