Bug 9692 - Add a checkbox to display statistical fields in basket.tt
Summary: Add a checkbox to display statistical fields in basket.tt
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2013-02-22 09:36 UTC by Mathieu Saby
Modified: 2018-03-30 13:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Add a checkbox to display statistical fields in basket.tt (5.61 KB, patch)
2013-02-22 09:44 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 9692: Add a checkbox to display statistical fields in basket.tt (5.66 KB, patch)
2013-03-18 15:22 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt (4.06 KB, patch)
2017-01-19 02:59 UTC, Emma
Details | Diff | Splinter Review
Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt (4.59 KB, patch)
2017-01-19 20:41 UTC, Emma
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-02-22 09:36:41 UTC
On the page displaying orders in a basket, there is a a checkbox to show "all details".
In fact, checking the box don't show all details, but only all prices.
It could be useful for librarians to see statistical fields on this page.

M. Saby
Rennes 2 University
Comment 1 Mathieu Saby 2013-02-22 09:44:14 UTC Comment hidden (obsolete)
Comment 2 Koha Team University Lyon 3 2013-03-18 13:31:32 UTC
ok, I can see statistical fields when "Show statistical fields" is checked and all the prices when "Show all prices" is checked and both if the 2 boxes are checked
Comment 3 Paul Poulain 2013-03-18 15:21:46 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 4 Paul Poulain 2013-03-18 15:22:02 UTC
Created attachment 16265 [details] [review]
Bug 9692: Add a checkbox to display statistical fields in basket.tt

This patch adds a checkbox in basket.tt to display the 2 statistical fields, and rename the "Show all details" checkbox to "Show all prices"
To test :
1. open a basket, with some orders comprising some values in statistical fields
2. check/uncheck the 2 boxes "Show all prices" and "Show statistical fields"

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Comment 5 Jonathan Druart 2013-03-18 15:53:40 UTC
QA comment:

There are 3 issues:
1/ The columns does not hide if I unselect the new checkbox
+            [% IF ( listincgst ) %]
+                $("table .statistics").hide();
+            [% ELSE %]
+                $("table .statistics").hide();
+            [% END %]

2/ If these fields (sort1 and sort2) are linked to an authorized value, the description should be displayed, not the code.

3/ 2 withespaces:
 * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt  FAIL
  forbidden patterns  FAIL
    The patch introduces a forbidden pattern: withespace character  (43)
    The patch introduces a forbidden pattern: withespace character  (35)

Marked as Failed QA.
Comment 6 Mathieu Saby 2013-03-18 15:59:17 UTC
Thank you, I will look after that tomorrow.
M. Saby
Comment 7 Marc Véron 2016-05-23 15:29:08 UTC
Still valid?
Comment 8 Emma 2017-01-19 02:59:08 UTC
Created attachment 59202 [details] [review]
Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt
Comment 9 Emma 2017-01-19 03:00:43 UTC
I was able to fix the merge conflicts and points 1 and 3 in Jonathan's comment, but I didn't understand point 2. This is ready to test if point 2 isn't a block.
Comment 10 Jonathan Druart 2017-01-19 08:13:21 UTC
Hi Emma,

CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt

First patch does not apply, could you send the patch you rebased please?
Comment 11 Emma 2017-01-19 20:41:06 UTC
Created attachment 59283 [details] [review]
Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt
Comment 12 Séverine Queune 2018-03-15 10:41:23 UTC
Second patch doesn't apply.

Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-9692-FOLLOWUP-Add-a-checkbox-to-display-statis-W5i0Tj.patch
Comment 13 Katrin Fischer 2018-03-30 13:43:43 UTC
I think the problem here is that we recenlty moved the Javascript to the bottom of the CC file. Resetting Asignee as Mathieu is no longer working on Koha. 

Still would be a good addition!